Improve navigation about puppeteer HOT 5 CLOSED

it could return the fetch response object for the main resource

from puppeteer.

Today, 'page.navigate' waits for the load event to fire. We might need an option to wait for DOMContentLoaded instead, though I don't know a scenario where this is useful.

from puppeteer.

example.com returns status 200 for all paths, so that non-existing-page case won't work. Is the idea to return false for non-200 status codes? I feel like the true/false should be whether or not the current page was rendered with data from that url. So 403/404/200 would be true, but timeout/brokenssl would be false.

from puppeteer.

Rather than false, to me it seems better to reject with an Error with a more descriptive message.

from puppeteer.

So the issue with returning true/false is that it's hard to decide what is a success and what is a failure. For example, navigating to a 404 page might be a valid scenario, since a lot of websites have their own custom-made 404's.

How about:

• we consider navigation failed if there's a navigation timeout or an interstitial
• anything else returns a status code for the main resource

This should address both @JoelEinbinder and @paulirish concerns. What do you guys think?

from puppeteer.