Git Product home page Git Product logo

Comments (4)

VenelinMartinov avatar VenelinMartinov commented on June 20, 2024 1

Two regression tests which are relevant here: TestSourceCodeHashImportedLambdaChecksCleanly and TestUpdateImportedLambda

from pulumi-aws.

t0yv0 avatar t0yv0 commented on June 20, 2024

Per #3959 this creates friction in routine upstrem upgrades. Digging up some more information here.

from pulumi-aws.

t0yv0 avatar t0yv0 commented on June 20, 2024

This has the back-history here: #3420

When importing lambdas, we run afoul of ExactlyOneOf due to a bridge issue, so the patch replaces that with ConflictsWith.

from pulumi-aws.

t0yv0 avatar t0yv0 commented on June 20, 2024

It looks really like a good example of pulumi/pulumi-terraform-bridge#1949

This is harder to automatically fix in the bridge.. It is indeed something that needs lambda-specific thought. We cannot plausibly manufacture a value here:

│ Error: Invalid combination of arguments
│
│   with aws_lambda_function.test_lambda,
│   on generated.tf line 4:
│   (source code not available)
│
│ "filename": one of `filename,image_uri,s3_bucket` must be specified
╵
╷
│ Error: Invalid combination of arguments
│
│   with aws_lambda_function.test_lambda,
│   on generated.tf line 7:
│   (source code not available)
│
│ "image_uri": one of `filename,image_uri,s3_bucket` must be specified
╵
╷
│ Error: Invalid combination of arguments
│
│   with aws_lambda_function.test_lambda,
│   on generated.tf line 16:
│   (source code not available)
│
│ "s3_bucket": one of `filename,image_uri,s3_bucket` must be specified

I think once we figure out a good answer to #3376 we can also revisit this patch.

from pulumi-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.