Comments (2)
iwahbe
commented on May 24, 2024
@t0yv0 My understanding is that we don't need to "test" the patch, since it is necessary to ensure our code compiles. If we make changes to the legacy bucket such that our code compiles without this patch, we are safe to remove this patch?
Does this sound right?
from pulumi-aws.
t0yv0
commented on May 24, 2024
Well that's a good point; that's one way to make the argument; but the other argument is for testing this is strong too. We're maintaining legacy bucket when upstream doesn't, has deleted the files and keeps changing things around. It could easily bit-rot and stop working. With this patch the use case I'm particularly concerned about is force-deletion, this is where this code is called. We could use making sure it's covered.
from pulumi-aws.
Related Issues (20)
- CloudFront KeyValueStore does not expose UUID as an output property HOT 5
- Workflow failure: Upgrade bridge HOT 3
- Upgrade terraform-provider-aws to v5.49.0
- PATCH 0057-Fix-empty-retry_strategy-of-Batch-JobDefinitions-cau.patch HOT 1
- Workflow failure: master HOT 2
- Improper partition used when generating SNS Topic ARN HOT 1
- lambda.Function `role` param is typed as optional but is required (Python) HOT 2
- Upgrade bridge to v3.82.0 HOT 3
- Workflow failure: master HOT 3
- TestRegress3196 Flake
- Inconsistent generated code HOT 1
- Workflow failure: cron HOT 1
- Upgrade terraform-provider-aws to v5.50.0 HOT 1
- Python type annotations don't match non-deprecated types HOT 1
- Pulumi destroy not working due to ENI attachment of deleted lambda HOT 2
- `error: internal error: Error: Missing newline after argument` on import of RouteTableAssociation with parent HOT 2
- PATCH 0054-Revert-r-aws_db_proxy-Change-auth-from-TypeList-to-T.patch
- PATCH 0046-Revert-rds-engine_version-Fix-bugs-with-default-only.patch HOT 1
- AWS_SKIP_CREDENTIALS_VALIDATION doesn't work HOT 2
- Epic: Lambda Builders HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulumi-aws.