Comments (4)
0.3
is not a Semantic Version number according to the definition. That is why the semver
package correctly does not parse it at
https://github.com/fabianschuiki/bender/blob/cd41a2a44517e22769dca9a5950db2d8359c7d9c/src/sess.rs#L555
@fabianschuiki: What is your view on this? Should we force package owners to define proper Semantic Version numbers, or should we assume 0.3
is equivalent to 0.3.0
(but what do we do if someone defines both 0.3
and 0.3.0
and the two are different?) and extend accordingly before invoking the semver
parser?
from bender.
That's a good catch. @accuminium I think your solution is nice: just assume 0.3
is equivalent to 0.3.0
, and then maybe if both are defined, opt for 0.3.0
as the "correct" one.
from bender.
The central disadvantage of the "assuming v0.3
== v0.3.0
unless there is a v0.3.0
" solution to me is that reproducibility is lost if a repository has v0.3
but not v0.3.0
when first users check it out, then later additionally has v0.3.0
to a different commit than v0.3
when other users check it out. Bender would report identical versions while the actual commits would be different.
I think we should not opt for that but instead ask repository owners to create SemVer-compliant tags. They can still keep their own-style tags if they want, and creating one extra tag per release is little effort.
from bender.
@accuminium You raise a valid point regarding the potential impact of simply assuming 0.3
to be 0.3.0
. Let's rather leave this with the repository owners. It's not hard to update a tag after the fact, so it's not like we are preventing any use by requiring proper tags.
from bender.
Related Issues (20)
- How to create a package? HOT 2
- Bender vendor support for upstream versions HOT 3
- Issue warning when file to include from upstream is not found HOT 1
- `bender vendor diff` does not display untracked files HOT 5
- vendor_package files are not added as source HOT 1
- Bender not updating git dependencies that have already been cloned HOT 1
- Possibility to release a build for macOS? HOT 2
- `plugins:` will be deprecated? HOT 3
- using environment variables in path dependencies HOT 2
- Citing bender
- Bug in `release.yaml`
- Bender ignores version tags HOT 2
- Package with only include_dirs doesn't work HOT 4
- Defines assumed to be string values, not numerical values
- VCS compile script doesn't propagate errors
- package filtering may fail HOT 1
- Tabs vs spaces HOT 3
- overrides doesn't seem to work in specifying a different branch - what am I doing wrong? HOT 4
- Why does `bender` look upward for a `Bender.local` even if it is run in a Bender repo?
- Latest release not available for platform 'x86_64-linux-gnu-pop22.04' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bender.