Git Product home page Git Product logo

Comments (7)

andreaskurth avatar andreaskurth commented on May 20, 2024

resp_t vs axi_pkg::resp_t conflict

I agree that using resp_t as parameter to hold the entire response struct is not ideal, since it could collide with axi_pkg::resp_t when the latter is imported into module namespace. However, with namespaces guarding from exactly such conflicts, I am against changing this to rsp_t right now. Can you check in which modules exactly the conflict happens?

For instance, there are wildcard imports in axi_cdc, axi_intf, axi_test, tb_axi_cdc, and tb_axi_atop_filter. Is one of those imports not bounded by a module scope? I would prefer to fix this problem this way.

Typedefs in axi_dw_upsizer

I agree with your solution. Please open a PR against the DWC branch.

from axi.

WRoenninger avatar WRoenninger commented on May 20, 2024

I had the problem also for example in axi_demux. There no import is happening.

from axi.

andreaskurth avatar andreaskurth commented on May 20, 2024

I see, but if one of the instances above is compiled before axi_demux and has a globally visible import, that could cause the problem, no?

from axi.

WRoenninger avatar WRoenninger commented on May 20, 2024

This was it, removing the global imports fixed the compile and simulation worked. See fixes in #70.

from axi.

fabianschuiki avatar fabianschuiki commented on May 20, 2024

Nice catch and fix! The compilation units in SV are really a pain.

from axi.

andreaskurth avatar andreaskurth commented on May 20, 2024

This can be closed now that #70 is merged, right?

from axi.

WRoenninger avatar WRoenninger commented on May 20, 2024

Yes #70 solved the compile issues, partially.
However Verilator does not like in the assertions in the interface AXI_BUS_DV in axi_interface.
Guarding them with

// pragma translate_off
`ifndef VERILATOR

`endif
// pragma translate_on

resolves the compile issue

from axi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.