Comments (1)
Hello Dustin,
Unfortunately, with only the Request
struct, there's not much that can be done to detect if the body is buffered, as for typical requests it will be wrapped in an unexported ioutil.NopCloser
by the call to http.NewRequest
, losing the type of the underlying reader. However, since Go 1.8, there's a new GetBody
field on the Request
that can be used to get a fresh copy of the body, saving the copying for the most usual in-memory body readers (bytes.Buffer/Reader, strings.Reader). For other types, it can be set by the caller. The request's body is also now set to the sentinel value http.NoBody
when the body is non-nil but known to be empty, this should also be checked by rehttp
.
Both of these new features should be checked before falling back on the current behaviour. The source code will need to be refactored a bit to use a Go1.8+ file and a pre-Go1.8 one.
Thanks for raising the idea, there's definitely something to be done to improve the package. Can't make any promises on when I'll have time to tackle this, though.
Martin
from rehttp.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rehttp.