Timeout property on goquery.NewDocument about goquery HOT 5 CLOSED

Hey Jordan,

NewDocument is just a helper func that uses the net/http default client (via http.Get), so whatever timeout you set on the default client (via its underlying transport) will be used. If you don't want to change the default client so that it doesn't interfere with other uses, then you can create your own http client, and pass the response to NewDocumentFromResponse instead.

from goquery.

Thanks! Looks like there isn't a very straightforward way at adding timeouts to Go's default client, does goquery support go-httpclient? Looks like this is a thin wrapper around the default but with timeout supported.

from goquery.

Yeah, setting timeouts is not super straightforward, you can see some options here: http://stackoverflow.com/questions/16895294/how-to-set-timeout-for-http-get-requests-in-golang

Goquery does not support other http clients, but there is a constructor based on an *http.Response (if this client returns stdlib's responses), or based on an io.Reader, so you should be able to get a goquery.Document one way or another.

from goquery.

Thanks Martin! That helped a lot and I have this up and working in production. Since go-httpclient returns the native http.Response I was able to use its timeout functionality and pass the response into goquery. Thanks for making such a flexible library!

from goquery.

Awesome, thanks for the kind words! Best of luck with your project!

from goquery.