Comments (6)
pcj
commented on July 27, 2024
1
Took awhile but should be fixed by #82
from rules_protobuf.
prestonvanloon
commented on July 27, 2024
I think this might be a duplicate of #67, but I did not see a fix committed.
from rules_protobuf.
pcj
commented on July 27, 2024
Yeah I need to get rid of that! Yeesh. I actually was working on that this morning and have a fix for the tests/external_proto... But it uncovered one other issue. Plan to get a fix for #67 and #79 later this evening.
from rules_protobuf.
prestonvanloon
commented on July 27, 2024
I'll see if I can send you a PR, if you haven't fixed it yet.
from rules_protobuf.
prestonvanloon
commented on July 27, 2024
I made some progress but running into a weird issue. https://github.com/prestonvanloon/rules_protobuf/blob/master/tests/external_proto_library/BUILD#L53
Not sure if this is the right approach. Let me know.
from rules_protobuf.
pcj
commented on July 27, 2024
Yep that's where I was going this AM as well, almost same workspace with googleapis.
The issue is in the go_proto_compile and cc_proto_compile whereby the output directory for either the files / descriptor set does not exist. Protoc does not like that. So there needs to be an extra 'mkdir' command inserted into the command list at https://github.com/prestonvanloon/rules_protobuf/blob/master/protobuf/internal/proto_compile.bzl#L372. I think I have a branch where this functionality exists (thought I fixed it already), so I will hunt that down.
from rules_protobuf.
Related Issues (20)
- Can't build GRPC when using cpp_proto_repositories HOT 5
- py_proto_library fails when taking input from a genrule HOT 1
- Not work with rules_go v0.13.0 HOT 3
- Dart support? HOT 4
- Go rules HOT 1
- Can't resolve @go_googleapis//google/api HOT 1
- Custom protoc generators HOT 1
- using imports in py_proto_compile fails: _pb2.py and pb2_grpc.py not created HOT 1
- gogo_proto_library with the "well known types" (google/protobuf) HOT 12
- Non repeatable build for grpc_cli HOT 1
- Update rules_protobuf to rules_go 0.16.0 HOT 7
- Addition of protoc-gen-grpc-web HOT 2
- 32-bit C++ compilation HOT 3
- including well known protos in ruby_proto_compile HOT 4
- support latest grpc version HOT 1
- Bazel deprecated native http_archive rule HOT 2
- Unable to load package for 'org_pubref_rules_protobuf/java/rules.bzl' HOT 1
- name 'FileType' is not defined HOT 2
- BUG: Error in label: label() got unexpected keyword argument 'single_file' HOT 2
- file '//protobuf:rules.bzl' does not contain symbol 'proto_compile'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rules_protobuf.