Git Product home page Git Product logo

Comments (5)

pcj avatar pcj commented on July 27, 2024

In this case one should not need this import statement, but I agree the rule should either not fail or give a better error message. I'll start looking into it.

from rules_protobuf.

swsnider avatar swsnider commented on July 27, 2024

I totally agree, but I have a situation where I have a need for the import statement, and this was just the minimal test case :).

from rules_protobuf.

pcj avatar pcj commented on July 27, 2024

I've changed go_proto_library from a genrule to rule implementation internally which should solve the issue you reported. Please try the v0.3.5 release.

However, there is still fairly poor support for imports. Will be working on that in the near term.

from rules_protobuf.

pcj avatar pcj commented on July 27, 2024

The v0.4.0 release https://github.com/pubref/rules_protobuf/releases/tag/v0.4.0 makes imports much better. Please try it out and either continue this thread or close it if resolved. Grats!

from rules_protobuf.

swsnider avatar swsnider commented on July 27, 2024

Thanks, but now I get a different error: #12. I assume that imports works better now, so I'll close this one.

from rules_protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.