Go vendoring duplicate library artifacts (glog, etc) about rules_protobuf HOT 4 CLOSED

I'll think about it a bit more, but off the top of my head, would this work?

1. Change the hardcoded entries in go/class.bzl compile_deps to an "//external:glog" form.
2. Support suppression of loading of unwanted deps, such as:

protobuf_repositories(
    exclude = ["com_github_golang_glog"]
)

bind(
   name = "glog", 
   actual = "//vendor/github.com/golang/glog"
)

Can you also try changing your dependency from the library to the source? (note the ".pb" implicit dependecy)? Curious if that is a workaround

go_library(
    name = "go_default_library",
    visibility = ["//visibility:public"],
    srcs = [
        "store.go",
        "//tools/artifact/proto:go_default_library.pb",
    ],
    deps = [
        "//vendor/github.com/golang/glog:go_default_library",
        "//vendor/google.golang.org/cloud/datastore:go_default_library",
    ],
)

from rules_protobuf.

Using bind was my thought as well and works for me. I will try the report back regarding the implicit .pb dependency tonight. Thanks Paul.

from rules_protobuf.

Did the bind solution work without forking?

from rules_protobuf.

The workaround resulted in

ERROR: /???/experiments.git/tools/artifact/db/BUILD:7:1: error executing shell command: 'rm -rf bazel-out/local-fastbuild/bin/tools/artifact/db/go_default_library.a.dir && mkdir -p bazel-out/local-fastbuild/bin/tools/artifact/db/go_default_library.a.dir && mkdir -p bazel-out/local-fast...' failed: linux-sandbox failed: error executing command /???/.cache/bazel/_bazel_bshi/08ef9c7ff335ac2219f037954496dcb0/execroot/experiments.git/_bin/linux-sandbox ... (remaining 5 argument(s) skipped).
???/experiments.git/tools/artifact/db/store.go:11: can't find import: "???/experiments.git/tools/artifact/proto"

Have not had a chance to investigate further. I haven't attempted the bind approach myself (no ETA unfortunately).

from rules_protobuf.