why didn't a yarn error trigger a failure in GitHub Actions? node version mismatch about mapknitter HOT 6 OPEN

When comparing the same or similar code (i believe, this was hours earlier than the above error, and merged), we saw no such error. But i think that's because default node version on GitHub Actions was higher than v13?

https://github.com/publiclab/mapknitter/runs/6374206383?check_suite_focus=true

The yarn error above was: error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 13.0.0". Got "12.22.7"

Do we need to do more to sync node versions?

from mapknitter.

Yes, GitHub Actions uses at least node v16! https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/

and indeed we just switched to v16 to fix this issue, as it's a LTS version. Should we fix this?

from mapknitter.

Note that Jenkins doesn't run the tests. And Google Cloud is yet another environment, although it will probably use the same files in dockerfiles/development and dockerfiles/production that we changed to upgrade to node v16: #1694

from mapknitter.

there is dockerfile support for GH Actions, makes sense... we could converge a bit... but is it worth it? https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions

from mapknitter.

Noting that we had a similar error of node v12 on production when we tried to publish the #1712 changes, somehow it's not v16 on production again...?

error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 13.0.0". Got "12.22.5"

from mapknitter.

Will try setting this here:

from mapknitter.