Make interactive confirm optionally accept return key for confirmation about pterm HOT 8 OPEN

@elfrucool I've added a draft that includes this new functionality. Would you like to take a look and offer some feedback?

from pterm.

I'll take a look once I get a moment

from pterm.

Thanks for the feedback! I understand your point. Although, in situations where pressing Enter is associated with confirmation, it might be confusing if the default action is "No" or "Cancel".

Also, most CLI prompts don't include a "confirmation helper text", so it might not be necessary here.

In my view, removing the helper text seems like the better option. However, let's wait for the maintainers to decide if they prefer your suggestion (adds more complexity to the printer) or if it's best to remove "confirmation helper text" altogether.

from pterm.

@MarvinJWendt, could you please share your thoughts on this?

from pterm.

What I could imagine is this:

• New option in the InteractiveConfirmPrinter called InstantSelect
  • If InstantSelect is true: Pressing y or n will instantly confirm or abort the printer.
  • If QuickSelect is false: Return is needed after pressing y or n to select
    • While Return is not pressed, the user should be able to switch between y or n
• InstantSelect should be true in DefaultInteractiveConfirm
  • That way, it can be disabled with .WithInstantSelect(false).

Any objections? :)

from pterm.

from pterm.

I had a similar idea, and I agree with @elfrucool. It seems more logical to have it disabled by default. In my PR, I added a new option WithConfirmation(true) to pterm.DefaultInteractiveConfirm to enable the behavior of waiting for the user to confirm their answer by pressing . Of course, naming is subject to change. 😄

from pterm.

Any updates on this? Waiting on this since its a great feature that helps prevent confusion on how the interactive confirm works in sequence with other inputs, such as the select or text input, which both require "Enter"

from pterm.