Wrong struct format of SceNetAdhocctlParams about pspsdk HOT 6 CLOSED

Thanks for your response! I will try to do some research about that, but I don't think I can take this. Maybe other people can solve this. Thanks again!

from pspsdk.

Hello @anr2me,
This is a really interesting question......
I have some "documentation around with version 6.60" and they show in the same format that we have, having nickname as the latest option.

However, if we take a look at PPSSPP they have :
https://github.com/hrydgard/ppsspp/blob/9271db09163d7ae3becd35c73decab0b3acad6d3/Core/HLE/proAdhoc.h#L284-L290

// Active Virtual Network Information (Adhoc Group Host/Creator's device info, similar to AP?)
typedef struct SceNetAdhocctlParameter {
  s32_le channel;
  SceNetAdhocctlGroupName group_name; // This group name is probably similar to SSID name on AP
  SceNetAdhocctlNickname nickname; // According to the old PSPSDK this is the bssid, but according to the dumped content when using newer firmware this is the nickname (this is also the nickname on VitaSDK)
  SceNetAdhocctlBSSId bssid; // FIXME: bssid and nickname position might be swapped on older/newer firmware?
} PACK SceNetAdhocc	tlParameter;

As you can see there is a funny comment // FIXME: bssid and nickname position might be swapped on older/newer firmware?

So actually I'm not sure about what values we should put

from pspsdk.

Hi @fjtrujy thanks for replying.

I'm the one that made that // FIXME: comment, because there is a game (Ys vs. Trails in the Sky Alternative Saga / NPJH50276) that shows a strange game room name as MAC address instead of Player's Nickname, which is wrong, but after swapping those fields it shows the game room correctly hrydgard/ppsspp#13493 (comment)

That game is for 6.20 firmware (based on it's PARAM.SFO), and i'm not sure whether the field was swapped on older firmware or not, which is why i added that FIXME comment for someone to confirm it.
So far there are no other games affected by those swapped fields, so i guess it's the correct order, which is also similar to the struct used on VitaSDK hrydgard/ppsspp#13393

I compared the content by putting a breakpoint on this game (Ys vs. Sora no Kiseki Alternative Saga) when calling sceNetAdhocctlGetParameter using JPCSP LLE (prx files from 6.60 ofw) and examined the outputted content's using JPCSP's MemoryViewer, which shows the correct Player's name / Game room on screen, where those fields are swapped based on the content in MemoryViewer.
While JPCSP HLE was using similar struct to PSPSDK, but i forgot whether the game doesn't run at all on HLE or shows the wrong game room / player's name on screen.

However, in order to confirm this, you'll probably need to check the content returned from sceNetAdhocctlGetParameter using a small homebrew, and testing it on a PSP using new and old firmware.

from pspsdk.

I want to try this issue, but I have only one PSP. Can I use this link: https://forums.ppsspp.org/showthread.php?tid=8349 to test it? The old version of firmware is 6.20, am I right? (By the way, I'm running 6.60 pro-c, but I will downgrade it to 6.20.) Do I need to use both the new and old are official firmware? thanks.

from pspsdk.

No, it should be older than 6.20 (may be try with 5.xx) to be compared with newest fw, since the game that known to use the new struct was designed for 6.20 fw (and newer may be?).

Regarding the PRO Online Client, I don't know whether the game is fully supported by legacy pro-online plugin or not, while PPSSPP have fixed some issue that came from legacy aemu/pro-online project (mostly issues related to AdhocMatching)

from pspsdk.

This has been resolved by #126

from pspsdk.