Optimization about pspsdk HOT 7 CLOSED

How does this look? https://github.com/uppfinnarn/pspsdk/commit/6287925b1dcffb3dccaafa40b0aa32420d5c18a1

I haven't tried it, since I'm not on a compute that can build this at the moment, but this sounds like what you said. Forking isn't difficult, but I can try to help with this anyways.

from pspsdk.

Hey, thanks for taking the time! I added some comments to the commit. It's not ok yet, but you should be able to fix it with the comments. The Buffer free-ing is fine. If I want to do something like that, do I just fork (get a copy?) and then make a pull request, or how would I go about that?

from pspsdk.

Just made 75dd05e to fix those. I'm just trying to blindly follow your instructions here.

And yeah, click the Fork button to get a repo called "DeadlySystem/pspsdk", make changes to that (preferably in a different branch, but master is fine for smaller changes), then press the big green "Pull Request" button to ask your changes to be pulled upstream (it shows up as a special kind of issue with all your commits attached). A contributor with commit access on this repo must then approve the request and merge it, which is as easy as clicking a button.

from pspsdk.

Okay, thanks for the explanation! I will try to do that next time. The code now looks good to me. I don't have a compiler at hand either right now, so I can't test it, but it should be fine. A test run should still be made, though. Thanks for taking care! Is it me who has to close the issue? If so, let me know - otherwise you can close it.

from pspsdk.

You can close it if you're done with it. Or leave it open and reference it from your pull request, then close it when it's merged - see https://help.github.com/articles/writing-on-github for details.

from pspsdk.

Okay, but that's for the future - I don't need to make a pull request for your commit now, do I? (I think only you can do it anyway). I'm not sure where that commit actually resides - it seems to be in pspdev/pspsdk, unlike the previous one - but I can't see it yet on the master branch, and there seems to be no other branch... I trust you will make sure it gets included?

from pspsdk.

It'd probably look better if you just made the changes yourself and pull-requested your version, that way you'll show up in the contributor list instead of me. And it's in uppfinnarn/pspsdk - my fork of pspdev/pspsdk. Just like if you fork it, there'll be a repo called DeadlySystem/pspsdk.

from pspsdk.