Fixing C82880 about tax-calculator HOT 6 CLOSED

Ilia, do you think it would be helpful to upload the SAS code that Dan used to generate withc.csv and then reference the relevant lines in that?

from tax-calculator.

On Wed, 8 Oct 2014, Ilia Kurenkov wrote:

My largest error is now concentrated in this variable and those derived from
it.
This variable first gets set here in Python and here in SAS. Below is a
table of relevant variables from a sample tax payer.

Variable Name
SAS value
Python Value
c82880
0
88250
e00200
88250
88250
e82882
0
0
e30100
0
0
_setax
0
0
_nctcr
1
1
_sey
0
0

Clearly, in both SAS and Python, the statements lead to c82880 being
assigned the value of e00200. However, we're not done with c82880 and it
gets reassigned here in Python and here in SAS. The weird thing is, it
appears that in SAS this statement is true gets executed, whereas in Python
we never hit it. I'm providing a table of relevant variables for the same
taxpayer below, which suggest that the reassignment should not in fact take
place. @feenberg, do you think there may have been modifications to this
segment recently?

Variable Name
SAS value
Python Value
_exact
0
0
e82880
0
0

I think there is a bug in the sas code. The line:

if _exact then c82880 = e82880;

should probably be

if _puf and _exact then c82880 = e82880;

but I have not tested it. I suggest that you set c82880 to zero for both
files and continue looking at other variables. However, this doesn't
answer the question of how c82880 got to be correct in Python when it is
wrong in SAS - I haven't looked at the Python for this code. I would like
to send you a new withc file, but my own taxcalc.sas is still broken, and
not in good shape to send to you. I was at the IRS trying to fix it
yesterday, but failed. I'll have a few days over the weekend and will fix
it for sure (hope) then. I think an uninitialized variable has gotten into
the calculation and made a hash of it. One charcater off can produce
chaos.

dan

—
Reply to this email directly or view it onGitHub.[8114261__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyODM5Mz
U0MywiZGF0YSI6eyJpZCI6NDUxNzI1ODB9fQ==--2f4050456bbdcd11030286e80b665261e0f
65a82.gif]

from tax-calculator.

Hmm, I tried setting c82880 to zero, but the accuracy didn't improve. When I looked at a sample taxpayer, it turned out that SAS was sometimes assigning values >0 to this variable. So I tried setting c82880 to e82880, but then realized that our Python code initializes it to an array of zeros...

from tax-calculator.

On Wed, 8 Oct 2014, Ilia Kurenkov wrote:

Hmm, I tried setting c82880 to zero, but the accuracy didn't improve. When I looked
at a sample taxpayer, it turned out that SAS was sometimes assigning values >0 to
this variable. So I tried setting c82880 to e82880, but then realized that our
Python code initializes it to an array of zeros...

I will send a new withc file this weekend, assuming I can fix my bugs. In
the meantime I don't have a solution to c82880 - it is mysterious. Try
looking at the other credits in the meantime. Do EIC and dependent care
match yet?

dan

—
Reply to this email directly or view it onGitHub.[8114261__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyODQ1MzIyNCwiZ
GF0YSI6eyJpZCI6NDUxNzI1ODB9fQ==--6fba39d6827e7758a68b5c81a4b731fface75cc1.gif]

from tax-calculator.

Is c33000 dependent care? The error for that variable is 5.00222085975111E-12.
As for EIC, I'm a lot less sure which c-code is relevant. Is it c59660? If yes, the error for it is 1.84925852408924E-9. Let me know if these are the variables you wanted.

from tax-calculator.

On Thu, 9 Oct 2014, Ilia Kurenkov wrote:

Is c33000 dependent care? The error for that variable is
5.00222085975111E-12.

That is zero.

As for EIC, I'm a lot less sure which c-code is relevant. Is it c59660? If
yes, the error for it is 1.84925852408924E-9. Let me know if these are the
variables you wanted.

That is EIC and it is also zero.

So you are good on both those. I will have a change in EIC when I send the
new withc, though.

dan

—
Reply to this email directly or view it onGitHub.[8114261__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyODQ4Mj
EyNywiZGF0YSI6eyJpZCI6NDUxNzI1ODB9fQ==--2d8599dbca596a40de3f65413366b7dfcf0
d7da6.gif]

from tax-calculator.