_nctcr Calculation about tax-calculator HOT 3 CLOSED

OK, I have a theory, correct me if I got it wrong.
xtxcr1-xtxcr10 is not a subtraction, as I originally thought, but a variable name. Then the of keyword indicates we are summing together elements of one vector instead of summing together several vectors element-wise.

from tax-calculator.

It just means take the sum of all 10 variables in the list xtxcr1-xtxcr10.
There is an example here:

http://support.sas.com/documentation/cdl/en/lrdict/64316/HTML/default/viewer.htm#a000245953.htm

dan

On Mon, 6 Oct 2014, Ilia Kurenkov wrote:

I've been able to track some of the few variables that still have
discrepancies to a difference in _nctcr.
As I look at the relevant SAS code I'm wondering what the statement sum(of
xtxcr1-xtxcr10); means, in particular the of keyword. Google didn't seem to
have an answer. @feenberg @MattHJensen @SameerSarkar

—
Reply to this email directly or view it onGitHub.[8114261__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyODIzMT
gxMywiZGF0YSI6eyJpZCI6NDQ5MTA0NDR9fQ==--1e53e4927bedc9d689248f7c91782b530aa
787ad.gif]

from tax-calculator.

Thank you for this. It appears there's nothing wrong with _nctcr, but there was a small mistake in how _precrd is computed. I fixed that, which led to improved accuracy. We're now down to a little over a dozen variables that are off.
BTW, is the max really necessary in max(0,_ctcagi - _cphase(MARS)) in this line if we never hit it unless _ctcagi - _cphase(MARS) >= 0? This is a minor question, however.

I'm closing the issue because the actual problem has been resolved.

from tax-calculator.