Git Product home page Git Product logo

Comments (5)

feenberg avatar feenberg commented on May 28, 2024

I don't understand. In the 1st paragraph you mention a discrepancy in c05100 but the links point to c05750, which looks correct in the code. c05100 depends on c24580, _feided and c04800 - do they match the SAS values?

dan

from tax-calculator.

feenberg avatar feenberg commented on May 28, 2024

Oh, I see, you have identified the problem as c24580. I am looking at that and wonder if there is a problem in the sas code. I'll look at it later this morning.

from tax-calculator.

feenberg avatar feenberg commented on May 28, 2024

I don't see why c24580 would be wrong. The pyton code appears to be equivalent to the sas code except that c24598 is omitted from the sum, which is correct since that value is not relevant after 2008. What values do you see for c24516, c24570 ,c24560 and _addtax? One of them must be wrong, and that would lead us closer to the error.

dan
617-863-0343

from tax-calculator.

iliakur avatar iliakur commented on May 28, 2024

For a sample taxpayer for whom c24580 differs, here's a table of relevant variables (for reference including c24580 itself):

Variable Name SAS value Python Value
c24580 2910.75 1995.75
c24516 0 0
c24570 0 0
c24560 0 0
addtax 0 0

from tax-calculator.

iliakur avatar iliakur commented on May 28, 2024

Having updated the python code to correspond with the August version of the SAS code, I registered a "basically zero" error for all of these values.
Closing this issue.

from tax-calculator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.