is the Taxer function doing what is desired? about tax-calculator HOT 6 CLOSED

@SameerSarkar is the best person to ask, since that line is missing from previous translations.

That function in general could do with some refactoring for an increase in speed and legibility.

from tax-calculator.

Still looking for input from @SameerSarkar on this issue.

from tax-calculator.

I'm hesitant to remove the code that uses _a1 though_a5 in the Taxer function, but it looks like that might be the right answer.

from tax-calculator.

I checked the SAS code and it appears _a1-_a5 are in fact used there. Based on a cursory read (during lunch break), I think they're just an optional logical branch if one's income satisfies certain conditions.

Considering this and that @SameerSarkar appears to have gone AWOL, my call would be to a) keep these lines b) translate them into vanilla python so that it's easier to figure out where and how they fit in.
I can totally help with the latter, so let me know!

from tax-calculator.

There is a lot of code in taxer to round the result in the same way that the the tax tables in the 1040 book are rounded. We don't need that in the long run, but it is useful to keep it while we are comparing with the withc data. I am virtually certain that taxer is doing the right thing - it has been compared to millions of actual returns at SOI, but the syntax may be limited by SAS, and it might look better as a loop rather than a series of conditional statements.

dan

from tax-calculator.

Closing.

from tax-calculator.