Generated command is wrong? about image-optimizer HOT 8 CLOSED

Which OS you are use? I just updated the package and now it works fine. Look in my install script:

  - wget http://de.archive.ubuntu.com/ubuntu/pool/universe/p/pngquant/pngquant_2.5.0-1_amd64.deb
  - sudo dpkg -i pngquant_2.5.0-1_amd64.deb

  - wget https://launchpad.net/ubuntu/+archive/primary/+files/gifsicle_1.88-1_amd64.deb
  - sudo dpkg -i gifsicle_1.88-1_amd64.deb

  - wget https://launchpad.net/ubuntu/+archive/primary/+files/jpegoptim_1.4.3-1_amd64.deb
  - sudo dpkg -i jpegoptim_1.4.3-1_amd64.deb

#  - sudo apt-get install -y pngquant gifsicle jpegoptim (not usable OS is old in travis)
  - pngquant --version # 2.5.0 (June 2015)
  - jpegoptim --version # jpegoptim v1.4.3  x86_64-pc-linux-gnu (libjpeg version: 8d  15-Jan-2012)
  - gifsicle --version # LCDF Gifsicle 1.88

from image-optimizer.

Same issue on my extended package.
https://travis-ci.org/approached/laravel-image-optimizer/jobs/151516271

Can try to give more write rights, like this:
chmod 777 -R /home/koichirose/public_html/dev/system/../assets/images/news/

from image-optimizer.

It works for me if I select "jpegoptim" manually. using the "smart" optimizer automatically select "jpegtran" and that command fails.

from image-optimizer.

I tested this issue for pngquant on Windows 8.1 and CentOS and get:

ImageOptimizer\Exception\Exception

Command failed, return code: 4, command: "D:\ImageOptimization\pngquant.exe" "--force" "--quality 70" "--ext=.png" "--" "D:\Development\PHP\tests\image-optimizer\a.png"

D:\ImageOptimization\pngquant.exe: unknown option -- quality 70

The generated command is wrong but this works fine (removing double quotes for --quality 70):

"D:\ImageOptimization\pngquant.exe" "--force" --quality 70 "--ext=.png" "--" "D:\Development\PHP\tests\image-optimizer\a.png"

from image-optimizer.

Just encountered this issue also, running PHP from the command line of an AWS server.

from image-optimizer.

I am not able to help if I won't get jpegtran and other stuff versions. Of course the output (from both: stdout and stderr) of the command generated by the library would be essential as well. @ChristianTheMinery Can you provide such info?

from image-optimizer.

Hi!
Jpegtran optimizer creates command with quoted jpegtran options. Like this "C:\Windows\jpegtran.EXE" "-optimize" "-progressive" "-copy none" "-outfile" "path-to-file" "path-to-file".

It is not works. If i run this command from cmd then jpegtran shows help screen and do nothing. With removed quotes it work well.

from image-optimizer.

Since 2.0.0 version a way of generating command has changed (symfony-process component is used), so it should not be a problem anymore.

from image-optimizer.