Git Product home page Git Product logo

Comments (7)

psifidotos avatar psifidotos commented on July 29, 2024 2

Yeah you are right, look at PaintedToolButton there is a property implicit Width, what do you think a good spacing would be for this?

Might be a good idea the GridLayout spacing to make it zero that would help also with Fitts Law and make the button implicit Width to use only one units.smallSpacing and not two

from applet-window-appmenu.

kupiqu avatar kupiqu commented on July 29, 2024

That is hard to compare in the screenshots, but there is space between the different buttons. I don't recall happening this before (neither in plasma's global menu), and I recall having to readjust the title applet to adjust for equal separation wrt the appmenu.

I would prefer not having separation between buttons in appmenu because the buttons margins bring separation themselves, and usually panels have more stuff other than the appmenu, so for applications with large number of menus, these extra space may make things to overlap and look bad.

Ideally, this space between buttons could be removed, or if someone for whatever reason thinks they are a good thing to have, then give an option to adjust that, so users can set it to 0 if wanted.

EDIT: the new screenshot is good

from applet-window-appmenu.

psifidotos avatar psifidotos commented on July 29, 2024

The difference is so small that I wouldn't consider it important. Spacing between menu elements is still units.smallSpacing like before... If anyone can find in the code other reason for the spacing I could look at it

from applet-window-appmenu.

kupiqu avatar kupiqu commented on July 29, 2024

what do you mean with If anyone can find in the code other reason for the spacing I could look at it ?

I don't understand the association between code and reason there, do you mean an alternative to units.smallSpacing?

from applet-window-appmenu.

psifidotos avatar psifidotos commented on July 29, 2024

I mean that plasma app menu is using units.smallSpacing also. If you think that this applet violates that somehow feel free to point me to where this happening

from applet-window-appmenu.

kupiqu avatar kupiqu commented on July 29, 2024

I mean that plasma app menu is using units.smallSpacing also. If you think that this applet violates that somehow feel free to point me to where this happening

I see. That's correct (I checked) but somehow buttons in plasma's global menu are closer together.

from applet-window-appmenu.

kupiqu avatar kupiqu commented on July 29, 2024

Yes, please.

from applet-window-appmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.