Comments (1)
Logging has been introduced.
This approach was used, to not mix cross-cutting concerns with business logic. Generally, it is Decorator pattern but thanks to functional paradigm its ends up with only appending a function in pipeline.
Was:
song
|> Validator.ValidateSong
|> bind ChordsProvider.GetChords
|> bind Engine.GetNumberOfHarmonies
Now:
song
|> Validator.ValidateSong
|> bind ChordsProvider.GetChords
|> bind Engine.GetNumberOfHarmonies
|> Logger.Log song
It was hard to choose a framework for Logger. First attempt was to introduce Logary which is written in F# for F#. However, there were a couple of obstacles.
- For simplicity I wanted to start with logging to file which seems to be somewhat hard to set with Logary
- I did not want to think how to set logger globally via code
The second relates to many other logging platforms. The one that provides a way to bypass these considerations is NLog. It allows to set the logger via configuration file which is just what is needed currently.
So, for now logging is trivial, it only logs unknown flavours together with the song where they are found. Logging runs locally, saves info to nearly hardcoded paths, not at hosting service. It all should be improved.
from chordinaryworld.
Related Issues (20)
- Handle too big count in GetTop HOT 1
- Move to .NET Core
- Separate Database logic
- Implement Singleton for DocumentClient
- Crawl Last.fm database for statistics HOT 1
- Consider modulations when counting harmonies
- Bring top of artist's songs by harmonies HOT 1
- Handle not found artist in last.fm HOT 1
- Validate artist for GetArtistTop HOT 1
- Add GetArtistTop functionality to Console client HOT 1
- Handle no tabs written for an artist HOT 1
- Move to Regex Type Provider HOT 1
- Handle unavailability of Chords Provider HOT 1
- Handle problems with tabs in GetArtistTop HOT 1
- Add GetArtistTop functionality to Web API HOT 1
- Add logging to GetTop HOT 1
- Add logging to GetArtistTop HOT 1
- Give formal credits to last.fm
- Propagate GetArtistTop to Web UI HOT 1
- Use local data for artist top
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chordinaryworld.