Git Product home page Git Product logo

Comments (5)

mmashwani avatar mmashwani commented on June 17, 2024

The problem with what your change is that you are now telling powershell.exe to exit with the actual value of LastExitCode as it currently stands when the command was executed. You would not get the correct exit code back from the execution of the Script1.ps1. Also, the semi-colon is required so that powershell.exe knows that these are two separate commands you are executing.

Thinking about it, I think the example should really be like so:

Execute-ProcessAsUser -Path "$PSHOME\powershell.exe" -Parameters '-Command `"C:\Test\Script.ps1`"; Exit `$LastExitCode' -Wait

I think there is a bug around the -File parameter for powershell.exe. It can't accept script blocks so the Exit command won't work with it. It also does not return the correct exit code and that bug will never be fixed due to Microsoft being super anal about maintaining backwards compatibility.

Test using the above example that uses the -Command parameter and let me know if that works for you. If so, then I will update the example given in the code.

from psappdeploytoolkit.

appPackager avatar appPackager commented on June 17, 2024

In performing further testing it appears that replacing "-file" with "-command" solves part of the issue but not all. When using the new command-line I now get a failure code: 1.

If I remove the escape (`) characters within the string like below I get success:
Execute-ProcessAsUser -Path "$PSHOME\powershell.exe" -Parameters '-Command "C:\Test\Script.ps1"; Exit $LastExitCode' -Wait

from psappdeploytoolkit.

mmashwani avatar mmashwani commented on June 17, 2024

I'm concerned that the above command will not exit with the correct exit code from the execution of Script.ps1 if that script were returning some custom exit code. I have not tested the below command, but I think it should work and it would guarantee that we get the correct exit code passed back to the task scheduler because the $LastExitCode variable would be enclosed in a script block. Basically, what I want to be able to do is not pass the value of the $LastExitCode variable from the current script to the exit statement of the script I want to execute as that would mean that exit code information from the script being executed would be lost. I hope that makes sense and this might not be useful for you in the case of this script, but it may be important in other instances.

Execute-ProcessAsUser -Path "$PSHOME\powershell.exe" -Parameters "-Command & { & `"C:\Test\Script.ps1`"; Exit `$LastExitCode }" -Wait

from psappdeploytoolkit.

appPackager avatar appPackager commented on June 17, 2024

I tried your last example and it works flawlessly. The psappdeploytoolkit log file logs an exit code of 0 upon successful execution of script.ps1 and also returns the proper error code from the script.ps1 when demanded. Can your latest example be added to Execute-ProcessAsUser help in place of the current?

from psappdeploytoolkit.

mmashwani avatar mmashwani commented on June 17, 2024

It's been updated in the latest beta.

from psappdeploytoolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.