Bug: One-off declarations on @psalm-params for Connection::executeUpdate && Connection::executeStatement about psalm-plugin-doctrine HOT 7 CLOSED

The error you get is because you're trying to push mixed[] to $params. I don't expect your proposal to make it any better. Replacing scalar[] by int[]|string[] restricts the type even more

from psalm-plugin-doctrine.

Heya @orklah, thank you for the correction. You are absolutely correct.

from psalm-plugin-doctrine.

definitions for $query and $types are off by one

Psalm matches params to docblock tags by parameter name.

from psalm-plugin-doctrine.

small error on my part, you didn't push mixed[] but array<string, mixed[]> but the conclusion was the same

from psalm-plugin-doctrine.

definitions for $query and $types are off by one

Psalm matches params to docblock tags by parameter name.

I know. I mixed it up when reading the param descriptions, the words "query" and "parameter" came off very prominent to me but the rest is history.

from psalm-plugin-doctrine.

Actually, we're getting hit with the same problem. I think that the updated stub introduced in #105 is incorrect, as the following code is perfectly valid, yet Psalm is complaining:

$this->entityManager->getConnection()->executeStatement($sql, [$uuids], [Connection::PARAM_STR_ARRAY]);

results in:

ERROR: InvalidArgument - some/path/Service.php:621:13 - Argument 2 of Doctrine\DBAL\Connection::executeStatement expects array<array-key, scalar>, array{int, array<array-key, mixed>} provided (see https://psalm.dev/004)
            [$uuids],

The doc block for the $params argument on the executeStatement method is:

@param array<int, mixed>|array<string, mixed> $params Statement parameters

Shouldn't the stub's parameter be mixed[] instead of scalar[] then?

from psalm-plugin-doctrine.

scalar[]|scalar[][] would probably be more helpful for users I think

Can you propose a PR?

from psalm-plugin-doctrine.