Git Product home page Git Product logo

Comments (5)

cderv avatar cderv commented on June 7, 2024 1

Yes you can do that (changing the options$engine) in your engine so that it is picked by Quarto 1.3.

In next version, the lang option will be respected.

from prqlc-r.

eitsupi avatar eitsupi commented on June 7, 2024

I am wondering if I need to add a test to check the rendering results by Quarto.
As Quarto is not an R package and would require an additional step when running on GHA.

There is also the issue of whether the Quarto R package should be added as a dependency......

from prqlc-r.

eitsupi avatar eitsupi commented on June 7, 2024

@cderv Thanks for your comment!
Does #110 look good?

from prqlc-r.

cderv avatar cderv commented on June 7, 2024

There is also the issue of whether the Quarto R package should be added as a dependency......

IMO you need only to add it (as Suggests) if you want to be thorough while adding a tests for Quarto in testthat while using skip_on_cran() and skip_if_not_installed(), and do snapshot test with markdown output.

Otherwise you could have a specific workflow that do a check without being a tests in R for example and in that case no need to add as a dependency, and no need to run very frequently your test.

By experience, hard to test everything that are output features. We'll check the knitr handling anyway.

from prqlc-r.

eitsupi avatar eitsupi commented on June 7, 2024

Otherwise you could have a specific workflow that do a check without being a tests in R for example and in that case no need to add as a dependency, and no need to run very frequently your test.

Indeed, this might be more appropriate here.
Since Quarto is updated frequently (thanks!), it seems to make sense to periodically run a test on GHA with installing the binary package prqlr from RSPM or R-universe and check the output.

from prqlc-r.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.