Git Product home page Git Product logo

Comments (3)

banks avatar banks commented on July 30, 2024

Extra info: since my authorizer is looking at the client TLS principal, it has to happen in proxy_on_downstream_data handler now since the proxy_on_new_connection one fires when the TCP connection is made before the TLS handshake (which makes sense as you may want to intercept the handshake too). Both of these handlers are limited to only returning Continue or Pause/StopIterarion currently though so it would seem there is no option to RST the connection from a filter currently?

from spec.

esnible avatar esnible commented on July 30, 2024

I am also trying to understand how to read this. I see proxy_on_http_request_body returns i32 (proxy_action_t) next_action.

I suspect the actions are the enumerations defined in https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/filter.h . Including the enumerations in the spec would help.

I suspect functions must abide by the same contract as Envoy extensions, e.g. the rules mentioned in https://www.envoyproxy.io/docs/envoy/latest/faq/extensions/contract.html#is-there-a-contract-my-http-filter-must-adhere-to . This is also not spelled out.

I have looked at native Envoy filter source code but never written one. The spec should incorporate, by value or by reference, sufficient information on enumerations and on state management.

from spec.

mathetake avatar mathetake commented on July 30, 2024

I believe this will be resolved by our project overhaul. Please refer to #39 (comment) for the context. Thanks!

from spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.