Proposal for a method without any special JavaScript code about inertiajs-events-laravel-dusk HOT 3 OPEN

Hey Pascal, thanks for the reply! In the meantime I contributed the waitForEvent() method to Dusk, which makes the process even easier (but would require Dusk >= v6.23.0).

Personally I switched from using a mixin to extending the Dusk Browser class with a custom InertiaBrowser class, in order to get IDE support while writing tests. In your BrowserTestCase base class you would use a ProvidesInertiaBrowser trait, which implements the newBrowser() method returning an InertiaBrowser instance.

I created a Gist to show what I mean: https://gist.github.com/michaelhue/6d62cd0470ecac2b21d296151e25fc76

What do you think? Would you prefer the inheritance or mixin approach?

from inertiajs-events-laravel-dusk.

Hi Michael, this looks great! This would eliminate some configuration setup while still providing the same functionality. If you would create PR, I'd definitely merge it. Thanks!

from inertiajs-events-laravel-dusk.

Requiring Dusk >= v6.23.0 is fine! I agree with you on IDE support. It's something I find frustrating with macros as well. Maybe you could implement the methods in a trait, so people can create their own custom browser and use the trait.

from inertiajs-events-laravel-dusk.