Comments (5)
Hey @daniel-j-h, I agree, that contrast theme needs some work. We at WWOOF decided to maintain our own theme since there wasn't clear consensus on the design specifications for a protomaps theme and we needed a more custom map design. Here's our theme (live), which is a slight deviation from the contrast theme. I'd love to see a community-supported contrast theme we could share! Looking forward to that contributed styles repo you speak of, Brandon!
export default {
hasCasings: true,
background: '#dddddd',
earth: '#ededed',
park: '#bfc99c',
hospital: '#ffeae8',
industrial: '#f8ffed',
school: '#f2fef9',
wood: '#bfc99c',
pedestrian: '#eef0f0',
scrub: '#bfc99c',
glacier: 'white',
sand: '#ebe7da',
aerodrome: '#dbe7e7',
runway: '#d1d9d9',
water: '#84b7cf',
zoo: '#EBE6ED',
tunnel_other_casing: '#ffffff',
tunnel_other: '#f7f7f7',
tunnel_minor_casing: '#e2e2e2',
tunnel_minor: '#ebebeb',
tunnel_medium_casing: '#e1e1e1',
tunnel_medium: '#ebebeb',
tunnel_major_casing: '#e3cfd3',
tunnel_major: '#ebebeb',
tunnel_highway_casing: '#ebcea2',
tunnel_highway: '#ebebeb',
buildings: '#cbcece',
other: '#ffffff',
minor_casing: '#e2e2e2',
minor: '#fff2bb',
medium_casing: '#e1e1e1',
medium: '#ffea94',
major_casing: '#e3cfd3',
major: '#ffdf59',
highway_casing: '#ebcea2',
highway: '#e9ac77',
railway: '#b3bcc9',
railway_tracks: '#ffffff',
boundaries: '#5c4a6b',
waterway_label_halo: 'white',
waterway_label: '#a4cae1',
bridges_other_casing: '#ffffff',
bridges_other: '#ffffff',
bridges_minor_casing: '#e2e2e2',
bridges_minor: 'white',
bridges_medium_casing: '#e1e1e1',
bridges_medium: '#ffffff',
bridges_major_casing: '#e3cfd3',
bridges_major: '#ffffff',
bridges_highway_casing: '#ebcea2',
bridges_highway: '#fefffc',
roads_label: '#91888b',
roads_label_halo: 'white',
ocean_label: 'white',
ocean_label_halo: '#a4cae1',
peak_label: '#61bb5b',
peak_label_halo: '#ffffff',
subplace_label: '#757d91',
subplace_label_halo: 'white',
city_circle: '#666666',
city_circle_stroke: 'white',
city_label: '#3c3c3c',
city_label_halo: 'white',
state_label: '#777777',
state_label_halo: 'white',
country_label: '#9590aa',
country_label_halo: 'white',
};
from basemaps.
Thanks for the feedback - the "Contrast" style was contributed by @cashc and isn't one of the five styles (light, dark, black, grayscale, white) I'm working on actively maintaining. In the future I would prefer to leave contributed styles to a separate repository, but in the meantime could you find a compromise change to improve the contrast of region labels that may appear over both land/water?
from basemaps.
Gotcha, I didn't know that and that makes perfectly sense! Maybe @cashc has thoughts here then 🙇
What would help is making it explicit e.g. in the readme or documentation that the light, dark, black, grayscale, and white styles are the main ones going forward. Just to set expectation for users 🤗
from basemaps.
Awesome @cashc that is gorgeous! Wondering if you want to submit a PR with those changes and we just update that contrast theme for now in this repo until we have found a better place for it.
from basemaps.
those changes are already in main
thanks to #46. I think what's needed is messing with the layers in styles/src/base_layers.ts
because I think there has been new layers added without new colors to support them and I suspect that's what's changed to cause the issues in your screenshot.
the project I'm working on has deviated our layers
from the protomaps/basemaps layers so that's why we're not experiencing these issues (yet, probably 😅)
from basemaps.
Related Issues (20)
- Missing boundaries in various places `pmap:min_admin_level 4` HOT 3
- Inconsistent naming and presence of disputed border attribute
- pmtiles center coordinates wrong (was:not able to render pmtiles file in maplibreGL) HOT 7
- Place labels in Uganda HOT 3
- Poor low-zoom generalization of linear water features comprised of areas HOT 1
- More simplification on country borders HOT 3
- Some landuse elements missing: village_green, allotments, playground HOT 6
- School Building heights are being incorrectly parsed/inferred HOT 3
- Rome vs Vatican State HOT 5
- Disconnected roads at zooms < 6 HOT 3
- Major road minzoom HOT 3
- More baselayers HOT 3
- make monaco fails on first run HOT 1
- better minzoom ranking for water labels HOT 1
- TS and JS build files of npm package out of sync HOT 19
- export 'default' (imported as 'layers') was not found in 'protomaps-themes-base' (module has no exports) HOT 5
- Add basic support for sprites HOT 5
- Mechanism for disputed map labels HOT 2
- Generate basemap with richer/more specific tags/layers HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from basemaps.