importing inner package protos leads to duplicate names about protobuf.js HOT 10 CLOSED

Yip, I was too stupid. Fixed it.
However, the issue remains, doesn't it?

btw, I love you for this project. ❤️

from protobuf.js.

There has been some progress on this lately: #38

Are you already using ProtoBuf.js >=1.1.1 (1.1.4 is latest)?

from protobuf.js.

Yes, I do. If you want, you can test it with node lib/schemas.

from protobuf.js.

I am sorry but I am still not sure what's the actual issue. Would you create a simple test case for me?

from protobuf.js.

This looks like the imports statements are not working... I'm trying a similar thing, using the same builder for each proto file gives the error:
Duplicate name in namespace Namespace .spotify.playlist4.proto: ListChecksum
whereas using a separate builder for each file gets one proto file further and gives the error:
Unresolvable type reference in Message.Field .spotify.playlist4.proto.Item.attributes: ItemAttributes

I'm trying to read and understand the docs and code, do we need to do anything special to use the import statements?

from protobuf.js.

If would already be sufficient if you could supply me with a simple test case that fails because I, unfortunately, have no understanding of the inheritance used in the spotify protos. I'll fix it then!

from protobuf.js.

I'm experiencing this problem using the proto2js command line utility. The issue arises when two proto files share a dependency. The depended-upon messages get loaded in twice.

Example:

in main.proto

package My;
import public "dep1.proto";
import public "dep2.proto";

message main {
    optional dep1 test1 = 0;
    optional dep2 test2 = 0;
}

in dep1.proto

package My;
import public "dep2.proto";

message dep1 {
    optional dep2 test1 = 0;
}

in dep2.proto

package My;

message dep2 {
    optional uint64 test1 = 0;
}

When I run proto2js main.proto -class='my' I get

my = dcodeIO.ProtoBuf.newBuilder().import(/* dep1 */).import(/* dep2 */).import(/* dep2 */)

Notice how dep2 gets loaded in duplicate.

from protobuf.js.

@adambom Nice repro steps!

from protobuf.js.

So, is this related to proto2js only?

from protobuf.js.

Have not attempted to repro the issue experienced by op.

Sent from my iPhone

On Aug 8, 2013, at 4:20 PM, dcode [email protected] wrote:

So, is this related to proto2js only?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/40#issuecomment-22365587
.

from protobuf.js.