Git Product home page Git Product logo

Comments (8)

steve9164 avatar steve9164 commented on July 17, 2024 2

Hi protobufjs maintainers. The 7.3.1 npm release is missing the dist folder. As far as I can tell this is a mistake - maybe the build processes needed before releasing didn't run properly. Would it be possible to release a 7.3.2 with this dist folder re-instated?

from protobuf.js.

dcodeIO avatar dcodeIO commented on July 17, 2024 1

Published a 7.3.2 manually now.

@sofisl : Regarding adding me to the protobufjs-cli package, I think that someone with access to Google's npm proxy would need to log in with google-wombot on npm, and add me to the protobufjs-cli package. Is separate from GitHub.

from protobuf.js.

basgroot avatar basgroot commented on July 17, 2024

..and the third one https://cdnjs.com/libraries/protobufjs, which also lists 7.3.0 as latest.

from protobuf.js.

dcodeIO avatar dcodeIO commented on July 17, 2024

Can confirm this issue. Appears the tooling we have in place only publishes to GitHub releases, but not to npm.

@protobufjs/maintainers : How was this done more recently? With a manual publish? If so, I'd need access to the protobufjs-cli package eventually, which is currently exclusively owned by google-wombot.

from protobuf.js.

alexander-fenster avatar alexander-fenster commented on July 17, 2024

I normally published both protobufjs and protobufjs-cli manually using the npm publish command using the internal instance of wombat dressing room NPM proxy. It just seems that v7.3.1 was never published to NPM. We (I should say "they" since I'm not with Google anymore) have automatic publishing set up for all googleapis packages, but not for protobuf.js (yet).

@sofisl Hi, long time no see :) Can you please run npm publish for v7.3.1, and also grant access to protobufjs-cli to Daniel (https://www.npmjs.com/~dcode)?

from protobuf.js.

sofisl avatar sofisl commented on July 17, 2024

Hi @alexander-fenster, seems like protobuf.js is now on 7.3.1 as latest! As for adding dcode, I don't think I can (I only have write access on this repo?)

from protobuf.js.

basgroot avatar basgroot commented on July 17, 2024

Thank for investigating this. Looks like the image in NPM is now showing the latest version: .

But as @steve9164 mentioned, this link lacks the dist folder: https://cdn.jsdelivr.net/npm/[email protected]/
The 7.3.0 has one: https://cdn.jsdelivr.net/npm/[email protected]/dist/

Same for this CDN: https://unpkg.com/[email protected]/dist/protobuf.min.js

from protobuf.js.

basgroot avatar basgroot commented on July 17, 2024

Thanks. All three are showing the latest again!

https://cdn.jsdelivr.net/npm/protobufjs/dist/
https://unpkg.com/browse/protobufjs/dist/
https://cdnjs.com/libraries/protobufjs/dist/

from protobuf.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.