message A { .... // some fields message B { ... // some fields

Finally also got the <a href="https://github.com/dcodeIO/ProtoBuf.js/commit/3c513e7eb3

I'm afraid the latest version still has bug here... E: odejs ode_m

Thanks for fixing my test case. 👍 I concur with <a class="user-ment

Encode/decode error when a child message have a long string data about protobuf.js HOT 8 CLOSED

protobufjs commented on July 23, 2024

Encode/decode error when a child message have a long string data

from protobuf.js.

Comments (8)

Dretch commented on July 23, 2024

I think I have run into the same bug. Here is a test case:

too-long-bug.proto:

message Foo {
    required Bar bar = 1;
}
message Bar {
    required string blah = 1;
}

too-long-bug.html:

<html>
<head>

    <script src="http://raw.github.com/dcodeIO/Long.js/master/Long.js"></script>
    <script src="http://raw.github.com/dcodeIO/ByteBuffer.js/master/ByteBuffer.js"></script>
    <script src="http://raw.github.com/dcodeIO/ProtoBuf.js/master/ProtoBuf.js"></script>

    <script type="text/javascript">

        var builder = dcodeIO.ProtoBuf.protoFromFile("too-long-bug.proto");
        var fooCls = builder.build("Foo");
        var barCls = builder.build("Bar");
        var foo = new fooCls(new barCls("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));
        var fooEncoded = foo.encode();
        var fooDecoded = fooCls.decode(fooEncoded);

    </script>

</head>
<body></body>
</html>

When the above file is opened in Chrome 26.0.1410.65 on OS X then the following javascript error occurs:

Uncaught Error: Illegal field id in Message .Bar#decode: 0

If the long string of "a...." is shorter (e.g. with a length of 3) then the error does not occur.

from protobuf.js.

shirmin commented on July 23, 2024

I check the binary buffer of encoding message which contain field of another message type.
When the child message over 128 bytes, the package length encode to 0x80(if 128 bytes) which should be encode as 2 bytes(in Varints).
That's why exception occurs.

from protobuf.js.

shirmin commented on July 23, 2024

I changed the ProtoBuf.js file to work temporarily, and hope author could fix it. Thanks.

from line: 1912

                var bb = new ByteBuffer();
                this.resolvedType.encode(value, bb);
                var messageBytes = bb.offset;
        buffer.writeVarint32(messageBytes);
        buffer.append(bb);
            } else {
                // We should never end here

from protobuf.js.

dcodeIO commented on July 23, 2024

Thank you everyone for pointing this out! I've implemented shirmin's fix and created a test case to ensure that it'll work from now on.

from protobuf.js.

dcodeIO commented on July 23, 2024

Finally also got the zero copy stuff for short inner message lengths working :)

from protobuf.js.

shirmin commented on July 23, 2024

I'm afraid the latest version still has bug here...

E:\nodejs\node_modules\protobufjs\node_modules\bytebuffer\ByteBuffer.js:582
throw("Cannot read uint8 from "+this+": Capacity overflow");
^
Cannot read uint8 from ByteBuffer(offset=770,markedOffset=-1,length=771,capacity
=771): Capacity overflow

from protobuf.js.

Dretch commented on July 23, 2024

Thanks for fixing my test case. 👍

I concur with @shirmin that there is still an issue somewhere. My original test case is now fixed, but this new test case fails.

too-long-bug-2.proto:

message Foo {
    required Bar bar = 1;
    required Baz baz = 2;
}
message Bar {
    required string blah = 1;
}
message Baz {
    required string blah = 1;
}

too-long-bug-2.html:

<html>
<head>

    <script src="http://raw.github.com/dcodeIO/Long.js/master/Long.js"></script>
    <script src="http://raw.github.com/dcodeIO/ByteBuffer.js/master/ByteBuffer.js"></script>
    <script src="http://raw.github.com/dcodeIO/ProtoBuf.js/master/ProtoBuf.js"></script>

    <script type="text/javascript">

        var str = "";
        for (var i=0; i<200; i++) {
            str += 'a';
        }

        var builder = dcodeIO.ProtoBuf.protoFromFile("too-long-bug-2.proto");
        var fooCls = builder.build("Foo");
        var barCls = builder.build("Bar");
        var bazCls = builder.build("Baz");
        var foo = new fooCls(new barCls(str), new bazCls(str));
        var fooEncoded = foo.encode();
        var fooDecoded = fooCls.decode(fooEncoded);

    </script>

</head>
<body></body>
</html>

When the above file is opened in Chrome 26.0.1410.65 on OS X then the following javascript error occurs:

Error: Illegal field id in Message .Foo#decode: 25

I guess this is the same underlying issue, because it seems to be related to the size of child messages. Changing the size of the str variable in the above example (to say, 100) makes the issue go away.

from protobuf.js.

dcodeIO commented on July 23, 2024

Ok, that's bad. I've reverted the zero copy stuff (it's actually not worth the trouble) and verified that your new test case works.

2769a1f

from protobuf.js.

Encode/decode error when a child message have a long string data about protobuf.js HOT 8 CLOSED

Comments (8)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent