Comments (6)
The returned classes are actually not a result of the builder alone, but also of turning the protocol reflection inside out. You can see it here:
https://github.com/dcodeIO/ProtoBuf.js/blob/master/src/ProtoBuf/Reflect.js
Think of them as an interface between the user and the reflected state that must always be built (which is pretty fast from json as there is no parsing involved). It's not possible to split that as it directly accesses all the core functionality of the library. Upside: No compilation step required :-)
For this reason I personally am not going to change the way it is currently.
from protobuf.js.
Oh ok, I assumed it would be non-trivial but I also didnt realise how tied in it was to everything :)
from protobuf.js.
slightly off-topic but on the same subject of proto2js builds - if you wanted to pre-package your protos and use import
, how would you handle this cli level? use case is say:
// Foo.proto
message Foo {
required string fizz = 1;
}
and
// Bar.proto
import "Foo.proto";
// really extend Bar but that produces an empty constructor.
message Bar {
required string buzz = 2;
}
running
node bin/proto2js tests/Bar.proto -amd
define(["ProtoBuf"], function(ProtoBuf) { return ProtoBuf.newBuilder().create([
{
"name": "Bar",
"fields": [
{
"rule": "required",
"type": "string",
"name": "buzz",
"id": 2,
"options": {}
}
],
"enums": [],
"messages": [],
"options": {}
}
]).build(); });
even the imports
array from the parser is being lost as the script only takes into account .messages
...
my use case is that I really need to get files that import
and extend
protos working w/o modding them. the parser just returns imports in an array but does not get the messages, which makes things confusing. I hope I am missing something... using tests from #10
from protobuf.js.
You are right, there is currently no import handling at all in proto2js. I will think about a solution and let you know!
from protobuf.js.
I've updated the proto2js utility to also include all imports when using the -class, -commonjs or -amd parameters. However, if this works in every single case might still need some testing :)
from protobuf.js.
yep. nice. I am gonna mod that to support extend now. incidentally:
$ node bin/proto2js tests/extend.proto -amd
Error: Illegal token in message FieldDescriptorProto: ; (type or '}' expected)
though it works, or at least does not throw w/o the amd / cjs switches.
from protobuf.js.
Related Issues (20)
- fromObject is not takin all arguments. HOT 1
- pbjs gives "Error: duplicate name 'Http' in Namespace .google.api"
- feat: add support for absolute imports HOT 1
- Error on proto files with external dependencies on protobuf.js version: 7.2.6
- Generation of types.d.ts breaks when the types.js is too big
- pbts produces incorrect typings for `message Object`
- Version `7.2.6` breaks build and throws an error `Error: ENOENT: no such file or directory, open ...` HOT 2
- Editions Suport
- Error: invalid wire type 6 at offset 297 is reported in the parsing field
- decode(new Uint8Array(data)) RangeError: index out of range: 97045 + 1 > 97045 HOT 1
- glob < 9 pulls in insecure depedendency, inflight HOT 1
- how to define protofile for [[1, 2, 3]]
- [Bug]Can not encode the embedded "oneof" keywords issue with sparkplugB schema
- Does it support running on quickjs?
- Prototype Pollution vulnerability HOT 6
- CustomError [ProtocolError]: missing required 'header'
- Support repeated options
- `pbts` does not generate comments for enum properties
- Descriptor binaries does not match the binaries generated using `protoc`
- Javascript enviroment, Json to protobuf text format
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf.js.