Comments (4)
from common.
I think that might be worthwhile, but I also think we should finally come to terms if we want to keep maintaining the various packages in common or not. IIRC @brian-brazil suggested to essentially deprecate everything here except expfmt
and maybe move the latter back into client_golang (from whence it originally cameβ¦).
It doesn't really make sense to refine the packages here if we want to deprecate them ASAP. (But do we?)
from common.
I think I need more context about why common
was created.
Does it have something to do with maintaining compatibility for important packages with proper semantic Go versioning? If yes then we might need to wait for consensus on that side. (e.g for our experiment with @Helcaraxan https://github.com/Helcaraxan/modularise-example-core)
If we want to keep this I would be happy to add extra methods here, no compatibility break anyway.
from common.
@brian-brazil will certainly be able to provide more context. To my knowledge, we created the common repo for code that is shared between other Prometheus (Go) repos, but we do not see it as outward facing libraries, so we are happy to break things here without warning and will only take care about usages within the Prometheus org. This should be clearly called out in the README.md, but currently isn't. Also there is the exception of expfmt
, which could be seen as the reference implementation for the Prometheus text format (generation and parsing). (And again, that fact is not really documented, either. We recently had a discussion about #33, where different opinions about the source of truth became apparent.) expfmt
was extracted here from client_golang because it was also used by the Prometheus server. That's not the case anymore, but it is still used by the Pushgateway.
The arrival of Go modules made things even more complicated, as we now essentially have to tag versions here to make Go modules work, but the various packages in common are essentially independent but now all tagged together.
from common.
Related Issues (20)
- expfmt: need to support gauge histogram metric type and float histogram HOT 1
- go mod graph will involve multi-versions of common and client_golang HOT 1
- Support custom `io/fs.FS` for HTTP clients HOT 6
- Expose SSL keys during debug HOT 1
- expfmt: TextDecoder infinite bufio Read recursion HOT 1
- Content negotiation is broken for expfmt and for promhttp HOT 3
- SigV4 client builder panics HOT 1
- Ability to configure SAN/CN validation for client certificates is missing
- Unable to remove specific label from a metric
- common v0.43.0 is not supporting kube-state-metrics v2.8.2 prometheus metrics format HOT 2
- NULL character on k8s zone labels
- Support environment variable for log level and format
- New release? HOT 3
- Implement changes needed to support UTF-8 metric and label names in Prometheus
- OAuth 2 client_secret should be optional
- LabelSet.String sorts incorrectly HOT 2
- Authorization credentials should be optional
- Update expfmt/text_parse.go to support the new UTF-8 syntax HOT 13
- SigV4 panics on GET requests / requests with nil body
- web: Support jwt/bearer token auth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from common.