Comments (5)
It appears that github.com/prometheus/node_exporter/https
exports everything needed to set the TLS context up in the same way as the node_exporter, which seems to me like a reasonable thing to do.
from collectd_exporter.
The change itself would be really simple, basically after importing https package and adding config file flag, it could be just:
- if err := http.ListenAndServe(*listenAddress, nil); err != nil {
+ server := &http.Server{Addr: *listenAddress}
+ if err := https.Listen(server, *tlsConfigFile, logger); err != nil {
but... using github.com/prometheus/node_exporter/https
bumps up dependencies in go.mod
require (
collectd.org v0.3.1-0.20181025072142-f80706d1e115
- github.com/go-kit/kit v0.8.0
- github.com/prometheus/client_golang v1.0.0
- github.com/prometheus/common v0.4.1
- golang.org/x/sys v0.0.0-20190422165155-953cdadca894 // indirect
+ github.com/go-kit/kit v0.10.0
+ github.com/prometheus/client_golang v1.4.1
+ github.com/prometheus/common v0.9.1
+ github.com/prometheus/node_exporter v1.0.0-rc.0.0.20200503194828-0c532984b7a6
gopkg.in/alecthomas/kingpin.v2 v2.2.6
)
which makes this change a lot heavier. Additionally, as make all
requires /vendor update with go mod vendor
, it would lead to:
467 files changed, 264071 insertions(+), 2576 deletions(-)
What approach do you recommend?
Thanks
from collectd_exporter.
We want to move the https package to github.com/prometheus/common before we start importing it into other projects. We're going through a security review of the code in the next couple months. When the security review is complete, we'll move the package.
from collectd_exporter.
I added #94 to get the vendoring up to date, should make this diff smaller.
from collectd_exporter.
TLS support is now included via the exporter-toolkit config.
from collectd_exporter.
Related Issues (20)
- Many errors when getting /metrics HOT 2
- Collected Exporter with heavy load HOT 5
- collectd_exporter - Prometheus target
- Not receiving any metrics from collectd HOT 1
- SPARC/Solaris compatibility HOT 1
- What's the role of this project vs collectd's write_prometheus plugin? HOT 2
- s390x support in CI HOT 3
- make fails with tcp timeout. HOT 1
- Metrics has different names that with write_prometheus
- errors in metrics output HOT 2
- metrics endpoint is broken with signalfx-metadata plugin
- Installation or Configuration documents
- error "*** was collected before with the same name and label values" HOT 4
- Prometheus collectd-exporter binary for s390x HOT 7
- Switch logging to go-kit
- Prefix to differentiate metrics from different clusters HOT 1
- Docker hub tags don't seem to be up to date HOT 4
- Arm builds HOT 2
- Feature request - Make Timeout configurable via a flag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collectd_exporter.