Comments (1)
Hey @ngoral, thanks for the bug report! This is a great catch and is very much a real issue.
Previously, before I added the code to correctly handle /
in job names, we were getting away with the implicit conversion of symbols into strings by ERB::Util::url_encode
:
irb(main):005:0> ERB::Util::url_encode(:hi)
=> "hi"
As you've noticed, symbols don't have include?
defined on them. It's also worth noting that Base64.urlsafe_encode64
won't perform the same conversion.
irb(main):001:0> :foo.include?("/")
(irb):1:in `<main>': undefined method `include?' for :foo:Symbol (NoMethodError)
...
irb(main):006:0> Base64.urlsafe_encode64(:hi)
<internal:pack>:8:in `pack': no implicit conversion of Symbol into String (TypeError)
I think you're right about the solution: we should convert job
into a string before using it inside this method. That matches what we do for metric labels (see also: the associated tests).
If you'd like to send us a PR to match that behaviour then I'll happily review it! If not, I'm happy to make the change on your behalf. Either way, thank you for bringing this to us rather than just working around it.
from client_ruby.
Related Issues (20)
- specifying ip-address and portnumber HOT 6
- CPU usage growing over time with DirectFileStore HOT 1
- better path handling HOT 14
- Update README.md with changes to pushgateway client
- Update CHANGELOG.md for 3.0.0 release HOT 1
- `generate_path` yields incorrect values for Sinatra+Rack::Build apps HOT 6
- Exporter port option doesn't work HOT 2
- Counter metric is reset when it has no labels HOT 8
- ERROR: Permission to prometheus/client_ruby.git denied HOT 2
- The rack example does not work because of `Rack::Lint::LintError` HOT 1
- Aaup HOT 1
- How to metrify ActiveRecord sql queries and Redis jobs (sidekiq/resque)? HOT 1
- pushing metrics with instance grouping_key would result: instance is reserved HOT 6
- Fix `Rack` deprecation warning
- Improving DirectFileStore for performance and scalability HOT 18
- Implement native histograms support HOT 4
- cannot load such file -- prometheus/middleware/collector (LoadError) HOT 2
- UTF-8: Implement support in Ruby client library HOT 5
- How can I change how paths are labelled? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client_ruby.