Comments (4)
I don't think we should presume that longs are ns, they could be ms if someone used currentTimeMillis. Both of those functions use different bases too (nanoTime isn't guaranteed to use the unix epoch). Thus a different approach is needed.
if responseStatusCode is a label, and its value isn't known until the request is finishing up, then the user has to fall back to using observe
It's generally recommended not to export latencies in this way, as there's a good chance a human will misinterpret the data.
from client_java.
It's generally recommended not to export latencies in this way, as there's a good chance a human will misinterpret the data.
Are you recommending against recording responseStatusCode
as a label? I would definitely want to learn more about the recommended way if you have any links or examples.
I agree regarding treating longs as nanos could cause confusion. I prefer the Timer
class to keep those details hidden. I've add #172 to demonstrate, since that was the core request of this issue.
from client_java.
Are you recommending against recording responseStatusCode as a label?
On latency metrics, yes.
I would definitely want to learn more about the recommended way if you have any links or examples.
One metric counting requests broken out by response code, another that's just latency.
from client_java.
Closed by #173
from client_java.
Related Issues (20)
- Endpoint actuator/prometheus not working on macOS HOT 1
- Publish a BOM again
- Implement latest changes in the Prometheus Protobuf format
- [httpserver exporter] No option to specify a wait time for ongoing requests when closing the server HOT 3
- Explicit Exception for Duplicate Labels during Scrape HOT 1
- Stress test failure in DropwizardExportsTest HOT 2
- Stress test failure in SlidingWindowTest HOT 1
- dropwizard5 MapperConfig doesn't rename the metric? HOT 4
- How to remove all metrics in the defaultRegistry HOT 5
- Failing while building simpleclient_httpserver version parent-0.15.0 using mvn clean install HOT 4
- log4j2 instrumentation support for 1.X?
- Flaky test - SlidingWindowTest
- Filter parameter causes HTTP Status 400 – Bad Request HOT 1
- info required for compatible version with openjdk21 HOT 2
- Counts in ClassicHistogramBuckets cannot be negative. HOT 1
- StatefulMetric clear() invocation causes noLabels increase to stop reporting on collect()
- Integrating Native Histograms with Spring 2.7.x and Prometheus client_java 1.3.1: Challenges in Writing Native Histograms to Response Object
- Inconsistencies between PrometheusNaming.sanitizeMetricName() methods
- UnknownDataPointSnapshot constructor ignores labels
- [FeatureRequest] Restore MetricsFilter in the servlet modules
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client_java.