Git Product home page Git Product logo

Comments (4)

brian-brazil avatar brian-brazil commented on September 7, 2024

I don't think we should presume that longs are ns, they could be ms if someone used currentTimeMillis. Both of those functions use different bases too (nanoTime isn't guaranteed to use the unix epoch). Thus a different approach is needed.

if responseStatusCode is a label, and its value isn't known until the request is finishing up, then the user has to fall back to using observe

It's generally recommended not to export latencies in this way, as there's a good chance a human will misinterpret the data.

from client_java.

checketts avatar checketts commented on September 7, 2024

It's generally recommended not to export latencies in this way, as there's a good chance a human will misinterpret the data.

Are you recommending against recording responseStatusCode as a label? I would definitely want to learn more about the recommended way if you have any links or examples.

I agree regarding treating longs as nanos could cause confusion. I prefer the Timer class to keep those details hidden. I've add #172 to demonstrate, since that was the core request of this issue.

from client_java.

brian-brazil avatar brian-brazil commented on September 7, 2024

Are you recommending against recording responseStatusCode as a label?

On latency metrics, yes.

I would definitely want to learn more about the recommended way if you have any links or examples.

One metric counting requests broken out by response code, another that's just latency.

from client_java.

checketts avatar checketts commented on September 7, 2024

Closed by #173

from client_java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.