Deprecate and/or rename push and pushAdd about client_java HOT 4 CLOSED

The naming is the standard naming for a Prometheus client, however the initial implementation in the Java client got them the wrong way around. The bug fix was clearly flagged in the release notes.

However, any Prometheus java client user will have its Prometheus fail silently just by upgrading the library.

I'd expect most users not to be affected, as touching all metrics is usual.

from client_java.

Just jumping in as a new prometheus user with a slight bit of confusion. I can't find any mention of a pushAll as mentioned above. When pushing metrics with the same name but different labels, the behaviour of the client is to replace any metric with that name, ignoring labels, is that correct? Is it not part of the purpose of prometheus labels to be able to query on them?

from client_java.

He meant pushAdd.

When pushing metrics with the same name but different labels, the behaviour of the client is to replace any metric with that name, ignoring labels, is that correct?

Yes, though within the grouping labels.

Is it not part of the purpose of prometheus labels to be able to query on them?

It is, I don't see how this relates to your question though.

from client_java.

I think you've cleared my confusion, thanks. There was a misunderstanding of how grouping keys are meant to correlate with labels.

from client_java.