Git Product home page Git Product logo

Comments (3)

grobinson-grafana avatar grobinson-grafana commented on September 2, 2024 1

@grobinson-grafana hi, a quick design question: The data types for this field would currently be identical to OpsGenieConfigResponder (config format) and opsGenieCreateMessageResponder (opsgenie api format).

Would you like me to reuse those struct types and reuse the code (maybe by extracting a function), or rather copy them as OpsGenieConfigVisibleTo and opsGenieCreateMessageVisibleTo and copy the code that handles them.

By copying, we avoid issues if there are fields or behaviour added to responders, that should not be added to visible_to, but it doesn't look as DRY. What do you think prefer?

I think let's do what it does for responders where it has separate struct definitions for the configuration file and for the request.

from alertmanager.

grobinson-grafana avatar grobinson-grafana commented on September 2, 2024

Seems reasonable to me! Please create a PR for this and I'll review it.

from alertmanager.

chlunde avatar chlunde commented on September 2, 2024

@grobinson-grafana hi, a quick design question: The data types for this field would currently be identical to OpsGenieConfigResponder (config format) and opsGenieCreateMessageResponder (opsgenie api format).

Would you like me to reuse those struct types and reuse the code (maybe by extracting a function), or rather copy them as OpsGenieConfigVisibleTo and opsGenieCreateMessageVisibleTo and copy the code that handles them.

By copying, we avoid issues if there are fields or behaviour added to responders, that should not be added to visible_to, but it doesn't look as DRY. What do you think prefer?

from alertmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.