Comments (3)
@grobinson-grafana hi, a quick design question: The data types for this field would currently be identical to
OpsGenieConfigResponder
(config format) andopsGenieCreateMessageResponder
(opsgenie api format).Would you like me to reuse those struct types and reuse the code (maybe by extracting a function), or rather copy them as
OpsGenieConfigVisibleTo
andopsGenieCreateMessageVisibleTo
and copy the code that handles them.By copying, we avoid issues if there are fields or behaviour added to responders, that should not be added to visible_to, but it doesn't look as DRY. What do you think prefer?
I think let's do what it does for responders
where it has separate struct definitions for the configuration file and for the request.
from alertmanager.
Seems reasonable to me! Please create a PR for this and I'll review it.
from alertmanager.
@grobinson-grafana hi, a quick design question: The data types for this field would currently be identical to OpsGenieConfigResponder
(config format) and opsGenieCreateMessageResponder
(opsgenie api format).
Would you like me to reuse those struct types and reuse the code (maybe by extracting a function), or rather copy them as OpsGenieConfigVisibleTo
and opsGenieCreateMessageVisibleTo
and copy the code that handles them.
By copying, we avoid issues if there are fields or behaviour added to responders, that should not be added to visible_to, but it doesn't look as DRY. What do you think prefer?
from alertmanager.
Related Issues (20)
- Microsoft deprecating Teams webhooks, new "Workflows" uses incompatible schema HOT 34
- Discord webhook : Cannot send an empty message HOT 4
- Feature Request: Enable Sending AdaptiveCards to Webex for Enhanced Alert Notifications
- Feature Request: Google cloud storage module
- Release a feature from a main branch HOT 2
- Inhibition rules evaluation performance on many target alerts HOT 5
- MS Teams alert card does not show info on mobile interface HOT 11
- Decode plus sign ('+') as a space (' ' or '%20') when decoding silence filters
- [feature request] matchers to work with annotations HOT 1
- Feature request: Add group creation time to group_by hash HOT 1
- Multiple vulnerabilities detected (govulncheck)
- Test certificates expiring in <2y
- Feature Request: Consider a Global Restriction on Silence Duration HOT 1
- Incorrect silence queryDuration metric HOT 1
- The gossip function is not working in webhook_configs.
- Add Metric Buckets for Notification Latency HOT 6
- Add docker tags for major/minor/patch versions HOT 3
- SMTP notifier does not await submission completion HOT 2
- Alertmanager sending duplicate notifications after 'resolved' notification when running with multiple replicas
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alertmanager.