Git Product home page Git Product logo

Comments (12)

Knappek avatar Knappek commented on May 20, 2024 1

Did somebody already start to work on that? If not, I would do so.

from prometheus-msteams.

bzon avatar bzon commented on May 20, 2024 1

@Knappek I haven’t planned on working on this yet. Feel free to play around and see how you can bring this feature to life. Thanks.

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

Just realized that a message card is not only limited to a size of 14KB but also to a maximum number of 10 sections (see https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/cards/cards-reference#notes-on-the-office-365-connector-card). Hence, we still have a bug that seemed to be fixed #29 . I will address this in the PR for this issue.

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

@bzon I have created another PR draft: #37. We might need to talk about how to handle too large message cards as I think this might not be possible anymore using this templating approach (see my last commit).
Therefore, I thought of make it super easy and send out a teams message for each and every prometheus alert.

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

@bzon is very busy these days, therefor I'd like to have some input from other folks. @LudwigTirazona @shabeermm @daviddob what do you think about sending out a teams message for each and every prometheus alert and don't combine multiple alerts to a single teams message card. Would that be a problem for you? I want to have your opinion on that as you were involved in #29.

from prometheus-msteams.

LudwigTirazona avatar LudwigTirazona commented on May 20, 2024

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

Good point, I didn't know about the MS Teams api rate limit. I agree that it is more appropriate to bundle alerts to single message cards...

Then I'd like to verify my assumptions how to split messages in case that they are too big: Referencing a detailed example teams message card we need to split the sections part as this is the part where we loop over the prometheus alerts as shown in this example card template, am I right?

from prometheus-msteams.

LudwigTirazona avatar LudwigTirazona commented on May 20, 2024

Correct! :)

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

PR #37 implements the functionality described in this issue. Just a few little things missing (like updating Readme etc.) that I will add in the upcoming days.
Would be great if some people can already test it and provide some feedback. @sosoriov this might be of interest for you as well.

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

@cordula-grau fyi, this enhancement solves #27 .

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

opened PR #37 . Would appreciate some code review, otherwise I'll merge it in the next couple of days and create the minor release 1.1.0.

from prometheus-msteams.

Knappek avatar Knappek commented on May 20, 2024

This feature is now available in v1.1.0 release.

from prometheus-msteams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.