feat(npmrc): Registry Auth Tokens about projen HOT 5 CLOSED

Oh boy...

Just ignore me. Thanks for the sounding board.

Closing because I cannot read. 🙈

from projen.

Another happy customer 😆

from projen.

Not sure I understand, but you'll probably create the PR yourself anyway. I'll leave you to it 😅

from projen.

Actually I will probably need your help, @mrgrain .

Currently this is implemented as an IniFile, which makes sense since even NPM says it is an INI-file. All examples below are from the page I linked.

This easily supports the patterns we currently have:

@myscope:registry=https://mycustomregistry.example.org for example, since INI are separated by equals.

BUT, npmrc has settings NOT separated by equals. Invalid comments are mine to point out the lines we cant support.

; bad config
_authToken=MYTOKEN # We could support this, if it worked.

; good config
@myorg:registry=https://somewhere-else.com/myorg
@another:registry=https://somewhere-else.com/another
//registry.npmjs.org/:_authToken=MYTOKEN # We can't support this
; would apply to both @myorg and @another
; //somewhere-else.com/:_authToken=MYTOKEN # We can't support this
; would apply only to @myorg
//somewhere-else.com/myorg/:_authToken=MYTOKEN1 # We can't support this
; would apply only to @another
//somewhere-else.com/another/:_authToken=MYTOKEN2 # We can't support this

We could move away from IniFile to TextFile, but I don't know all the implications.

from projen.

I'm still lost. All of these lines are separated by a =? 🤔

Implication of using a TextFile is more work, and we loose the features of IniFile. I'd rather fix the problems with IniFile

from projen.