links deSerialize problem about react-diagrams HOT 13 CLOSED

Hi, Thanks for looking into this. I have created a small example. When app is running clicking save, clear, load buttons reproduces the issue.

from react-diagrams.

Thanks for taking the time to do this, Ill jump onto this shortly and see what I can do.

from react-diagrams.

Fixed in 2.5.2

from react-diagrams.

does this still happen in the 2.4.8?

from react-diagrams.

Yes, it throws an error now "Cannot find Node Port element with nodeID:..."
It looks like just fired before the model was serialized.
I am making a request to a server and trying to serialize the model.

how code looks like

componentDidMount() {

    API.httpGet('/stage')
      .then((stageJson) => {
        let model2 = new SRD.DiagramModel();
        this.state.engine.setDiagramModel(model2);
        model2.deSerializeDiagram(stageJson, this.state.engine);
        subscribeModel(model2); //subscribe to model events
        this.setState({model:model2});
        _.each(model2.getNodes(),subscribeNode.bind(this)); //subscribe to node events
        this.forceUpdate()
      });
  }

from react-diagrams.

I had the same error. I created a new LinkWidget and LinkFactory. I'm searching where can be the problem.

from react-diagrams.

I a workaround that I made is reimporting 2 times, with a timeout of 100 milliseconds.

  serializationImport() {
    try {
      // Parse the JSON
      let object = JSON.parse(this.state.serializationInput);

      // Create a new Model
      let newModel = new SRD.DiagramModel();
      newModel.deSerializeDiagram(object, this.engine);

      // Render the `newModel`
      this.model = newModel;
      this.engine.setDiagramModel(newModel);
      this.forceUpdate();

      this._tempTimeout = setTimeout(() => {
        this.serializationImport();
        clearTimeout(this._tempTimeout);
      }, 100);

    } finally {
      this.toggleSerializationModal();
    }
  }

from react-diagrams.

I have a similar issue. I am using default factories. When I deserialize the diagram with a new engine and empty model links don't get created with an error like

Cannot find Node Port element with nodeID: [1e0a6c3f-592b-49ab-a953-0b8eb67e1a55] and name: [sensorValue]

If I deserialize the model twice links appear. Probably something to do with deserialization order. Nodes need to be created before the links are created. I can see this in the logs as well, first links are added and then removed due to the node not found error message.

from react-diagrams.

arghhh race conditions :C If you can provide me with a test case ill try fix it

from react-diagrams.

Any update on this?

from react-diagrams.

Hold on, I think I got it. I'll send a PR in a few minutes.

from react-diagrams.

I think this is fixed in PR #80 , can anyone confirm?

from react-diagrams.

Fixed in caadbf4

from react-diagrams.