Git Product home page Git Product logo

Comments (7)

zbraniecki avatar zbraniecki commented on June 10, 2024 1

For the errors - we could swap to accept a mutable reference to a trait object that implements push_error. You can make it a no-op and default impl for Vec.

For args - this is a bit more tricky. I'm not sure if an iterator is actually saving us here, and I suspect it would incur a perf penalty. What we could do, again, is swap it for a trait that you can implement for Vec, HashMap, and your own type.

I'm open to PRs!

from fluent-rs.

zicklag avatar zicklag commented on June 10, 2024

I might be interested in contributing for this if it's something you guys are interested in.

from fluent-rs.

zicklag avatar zicklag commented on June 10, 2024

Oh, good idea, I didn't think of using trait objects!

I think I'll try that out if I get the chance and open a PR if it looks like it works.

from fluent-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.