okhttp to retrofit and some rxJava? about travel-mate HOT 16 CLOSED

I know, Retrofit code is cleaner, and easier to read. If you come across any other benefit too, mention it here.
I thought it would be a lot of effort to do this task. If you would like to work on moving the code from okhttp to retrofit. you are welcome. :)

from travel-mate.

@Swati4star yeap i would work on it , i have exams right now , so i will start working in few days

from travel-mate.

Ok, i'll start with Destinations module and will use Retrofit 2.0+ and GSON converter factory.

from travel-mate.

@gugakatsi Can you list some advantage of why should I use retrofit, instead of okhttp?

from travel-mate.

@Swati4star of course, so first of all maybe i am wrong here so that's why i wrote ? at the end :D so don't judge me , without a doubt retrofit code i guess cleaner and much easier to read right? also it's really handsome while you're decomposing app for example, also it is great with alongside with rxJava, i don't know this about okhttp and also retrofit also uses okhttp in some situations when it's needed, so i think it's kinda more modern now , :D that was all i could say

from travel-mate.

Great. Just post a message over here when you will start working on it.

from travel-mate.

Is the issue still open ?

from travel-mate.

from travel-mate.

Is there a way i could contribute too?

from travel-mate.

Sure , check issue #10 and write on which module you gonna work

from travel-mate.

Greetings of the day!
I want to contribute to this project and i think i'll be helpful in shifting the project from okhttp to retrofit. Please let me know if i can proceed and also tell me the module name to start the process with.
Thanks!

from travel-mate.

@Sumeet-Rukeja sorry for late response , i'll write down tomorrow evening .

from travel-mate.

Hi, any updates on this issue??

from travel-mate.

@Sumeet-Rukeja , make indepedent package data and inside that remote package , start with destinations module , refactor those okHttp to RetroFit . tell me what you think about that.

from travel-mate.

Hi @gugakatsi @Swati4star, i have completed integrating retrofit in Destinations module and have created a pull request . Please, verify it and let me know about the next module to continue this process.

from travel-mate.

Closing this one & will break this issue into multiple smaller issues.

from travel-mate.