Git Product home page Git Product logo

Comments (22)

laurencefass avatar laurencefass commented on September 6, 2024

Hi just double checked it. Im Sure its disabled. IMHO graying on hover as a UX feature is a bit confusing, but definitely not doing anything and not swapping. specifically: no confirmation (or anything) and balances remain unchanged.

Specifically Im trying to swap 0.1 SOL for SRM/RAY etc just to prove it works. I only have one SOL in the wallet (more to come once ive proved its safe and swaps are working ok....). Could the account balance and swap amounts be too small?

Im happy to help test this and can provide any diagnostic data you need.

Thanks

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Hi do you have any more feedback common access via sollet.io so should be a reproducible issue.

Generally is this the best channel for user-land support? Do you have a better support channel than github that is not discord. Email support would be more structured. I have been using Atomic Wallet recently and the email support is first class and certainly a good model to work for any organisation supporting a wallet.

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

Github is best for developer issues and Discord is best for more interactive support non-development issues.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Thanks. This looks like a pretty fundamental issue and I cant see I am doing anything wrong. Whats the best way to continue testing this particular issue? Basic SPL swaps not working... Can you confirm the same issue?

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

Thanks. This looks like a pretty fundamental issue and I cant see I am doing anything wrong. Whats the best way to continue testing this particular issue? Basic SPL swaps not working... Can you confirm the same issue?

I cannot reproduce the issue described. The only thing I can think of is that you either don't have the spl token accounts created or your balances are zero.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

I sent a screenshot showing non-zero balance for sol.
https://user-images.githubusercontent.com/3512857/123796974-9d198700-d8dd-11eb-8b18-1ec0d5fa89d7.png

Please can you advise further what you mean by SPL token accounts. Do I need to do something other than add new tokens? Do I need to create new accounts for each token I add?

Thanks

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

I sent a screenshot showing non-zero balance for sol.
https://user-images.githubusercontent.com/3512857/123796974-9d198700-d8dd-11eb-8b18-1ec0d5fa89d7.png

Please can you advise further what you mean by SPL token accounts. Do I need to do something other than add new tokens? Do I need to create new accounts for each token I add?

Thanks

Please share your browser console logs. Right click. Inspect. A tab bar should popup. Click console and share the screenshot.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Thanks. No errors just unable to swap. I appended other tokens to the list by selecting them from the Add Token (+).

image

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Clicking swap on sollet.io (MAINNET BETA) did raise an error:

2.68c69cb7.chunk.js:1 Uncaught (in promise) Error: SOL must be swapped in a single transaction
    at 2.68c69cb7.chunk.js:1
    at 2.68c69cb7.chunk.js:1
    at Object.next (2.68c69cb7.chunk.js:1)
    at a (2.68c69cb7.chunk.js:1)

It only does this on the first click until close and re-open the Swap dialog and reclick

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

The ultimate problem is that you don't have a bunch of pre-requisite accounts setup. Specifically,

  • usdc
  • sol/usdc open orders account
  • srm/usdc open orders account

The work around for this would be for you to swap on the individual markets listed in the info dialog's trade route. Once you've done that you can swap.

To properly solve this, the swapper should provide explicit flows for these cases, similar to #62. The alternative would be to batch transactions--since, in this case, the transaction is broken up into several to work around the tx size limit--but rpc nodes aren't reliable enough to support that at the moment, so explicit flows are the better choice.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

This advice is quite low level and confusing offering a lot of undocumented(?) advice. The error message states the need to complete a single transaction but you are also advising the need to perform a complex series of prerequisite actions just to swap SOL for SRM (or any SPL token).

Im also confused by advice to obtain USDC? What is this for? Why is there a USDC intermediary between SOL and SPL tokens? This doesnt sound correct. If it is correct is this documented?

If what you say regarding pre-requisite accounts and USDC is correct the basic sollet.io wallet swap function is too complex for users who just want to hold SOL and SPL tokens in a wallet. This is the most complex swap I've encountered in crypto-land and less intutive than direct market trading on a CEX. Also the UI does not advise on correct method and just silently fails without issuing error.

I hope you can consider this as constructive feedback I really want to use sollet.io so I am happy to assist to make swapping easier.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Can you confirm that I have set up the correct accounts from the screenshot? Do I need to create additional entities other than those shown? OR perhaps in another screen?

As you can see I have only a single account with multiple (token) balances. Is the prerequisite set of accounts you refer to? If this is incorrect is there any documentation advising on how way to swap through sollet.io and USDC?

The prerequisites you describe sound too complex too perform a simple swap from SOL to SRM. Do I really need:

usdc
sol/usdc open orders account
srm/usdc open orders accounts

to swap SOL to SRM/RAY/XY etc through the wallet?

I think other instructions may be too low level and complex for an average user wanting to use this wallet.

The error I received was: SOL must be swapped in a single transaction.

The work around for this would be for you to swap on the individual markets listed in the info dialog's trade route. Once you've done that you can swap. To properly solve this, the swapper should provide explicit flows for these cases, similar to #62. The alternative would be to batch transactions--since, in this case, the transaction is broken up into several to work around the tx size limit--but rpc nodes aren't reliable enough to support that at the moment, so explicit flows are the better choice.

I dont undertstand any of these instructions and it sounds quite low level for a sollet.io user to understand. A simple swap has a standard interface in most wallets, CEX and DEX and doesnt require any additional prerequisite other than a source token fund to initiate the swap.

I appreciate your time and attention in trying to assist. If this issue is not resolvable here please can you refer to the correct instructions for completing a straight SOL->SRM swap.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

this is screenshot showing a funded account and the immediate console.log result of clicking swap. I have not set up any other external accounts other than the wallet account you see here, and I have added a variety of SPL tokens through the interface as the only prerequisite to making the swap.

image

Please let me know if need further information or diagnostics. I am very happy to assist to help improve the UX flow for these swaps.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Are you able to duplicate this issue and is it expected at this stage of development. i.e. Is a simple Swap from SOL to SPL (e.g. SRM) token still a WIP and dependent upon USDC? Can you further clarify the role of USDC and the prerequisite account requirements as this has left me somewhat confused over the SOL/SPL swap process in general?

I hope to be able use sollet.io regularly in the future and I would like to avoid making inappropriate posts to the wrong place to discuss issues if they arise. To ease further communication please can you advise if you consider this a developer issue, a misuse of the wallet, a lack of understanding the solliet.io interface, a lack of documentation, or possibly a combination of factors?

I was expecting a 1-2 click swap process and Im not sure if sollet.io is meant to work like that, or if I am doing something incorrectly? Im certainly confused by reference to USDC and Im sure other users may feel the same. I am still unclear as to what to expect in terms of a user experience to swap SOL to SPL. A simple online guide as to how its meant to work would be most helpful.

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

It's not a bug. But it's a bad user experience. This is being addressed in #64.

USDC comes from the fact that you were performing a transitive swap that trades across two markets. The UI only routes trades via USD(x) markets since they have the best liquidity. See the "info" popup.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

I have read: "USDC is an ERC-20 token issued on the Ethereum blockchain and can be stored in any Ethereum wallet" so Im unsure why sollet.io is performing what is essentially a native swap (SOL->SPL token) via an ethereum token.

Am I understanding this correctly? I am investigating SOLANA as an alternative to the Ethereum network and I dont really understand why native swaps are taking place on the ethereum network.

My main concern with this is charged Ethereum/ERC20 fees and experiencing all of the performance bottlenecks currently experienced on the etherium blockchain.

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024

USDC is on both ethereum and solana natively. So from the swap program's perspective, it's just another SPL token.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Great this useful to know. So is the swap is occuring entirely on the Solana network without incurring Ethereum charges?

Given the UI in its current form please can you provide some simple steps to perform a swap from SOL (native) to SRM (native) so that my balance shows SRM deposited into my account. Do I need USDC to perform the swap? If not whats the best way to proceed?

Thanks

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

Perhaps this issue should have started and ended with "how do i swap SOL for SRM in sollet.io?"

from swap-ui.

armaniferrante avatar armaniferrante commented on September 6, 2024
  1. Create a USDC token account
  2. Swap from SOL -> USDC
  3. Swap from USDC -> SPL token

That should create all the requisite accounts.

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

The swap from SOL To USDC failed.

image

Should I have tried the swap from SOL to WUSDC?

from swap-ui.

laurencefass avatar laurencefass commented on September 6, 2024

ok i tried again and it worked fine.

It would be great to miss out the USDC step if possible.

I dont know how much the swaps cost. Can i see that anywhere in the sollet.io wallet?

thanks

from swap-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.