Git Product home page Git Product logo

Comments (2)

brightredchilli avatar brightredchilli commented on July 18, 2024

Hm, looks like some discussion needed here.

The keyPressed function is currently bound to the onkeydown event.

document.body.onkeydown=function(e){
      pKeyPressed = true;
      if (typeof keyPressed === 'function')
        keyPressed(e);
    }    

but we are setting keyCode only on the keypress event.

 document.body.onkeypress=function(e){                                                                              
      keyCode = e.keyCode;
      if (typeof keyTyped === 'function')
        keyTyped(e);
    }    

The bigger issue here is that keyCode only has the correct ASCII representation in onkeypress(Chrome 29.0.1547.57, Firefox 23.0.1). For now, this brightredchilli/processing-js@5fc0667 has a temporary fix, just setting the keyCode in two places. This will at least give some default values to work with.

from p5.js.

lmccart avatar lmccart commented on July 18, 2024

closing for now. also removing the keycode and key set in onkeypress, this relates to a different code than the keyup and down events which refer to the physical key.

we can look at this when we implement with cross browser support later:
http://unixpapa.com/js/key.html

from p5.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.