Comments (6)
Hmmm...I'm not sure if this is a problem or if it's doing what it's supposed to do? When you log it will change to the language from your account preferences. In your video that was English.
It does not always change to English when logging in -- it happens to do so in this example because English is the language that you were last using when you logged out.
Let's say that I'm logged in and I change my preferences to Spanish. Then I log out and I change it to French. Then I log in. The language will be Spanish because that is the language associated with my account.
from p5.js-web-editor.
I was reading about this issue and was thinking whether we would proceed with changing it so the language stays the same before login session rather than storing it as a language associated with the account?
from p5.js-web-editor.
Hmmm...I'm not sure if this is a problem or if it's doing what it's supposed to do? When you log it will change to the language from your account preferences. In your video that was English.
It does not always change to English when logging in -- it happens to do so in this example because English is the language that you were last using when you logged out.
Let's say that I'm logged in and I change my preferences to Spanish. Then I log out and I change it to French. Then I log in. The language will be Spanish because that is the language associated with my account.
I think, it is not good from user-experience of non-technical user perspective.
We can solve this issue as follows:
Saving the selected language preference in local storage when a user is logged out and then syncing that preference to the backend upon login.
If this approach is right, I am interested to work on it, please assign it to me.
from p5.js-web-editor.
@lindapaiste I just need your confirmation to start working on this issue because I have already figured out how to do this.
from p5.js-web-editor.
I agree with @lindapaiste. This works as intended. Languages should be tied to the last preference of a specific account. Multiple users can be using the same computer with different accounts (say, in a school computer lab) so keeping languages tied to account preferences is the way to go.
from p5.js-web-editor.
I think that's how I'm feeling so far here as well. I'm not sure if this is something we might want to consider in the near future so I'm going to close this for now, but am down to reopen this if more interest in this issue resurfaces!
from p5.js-web-editor.
Related Issues (20)
- Delete sketch fails HOT 6
- Can't not delete any of my sketches HOT 5
- API Returning Unathorized HOT 6
- refactor react-redux in `AssetSize` component
- Introducing Key-based Action Execution: Enhancing Efficiency and User Experience HOT 4
- Make the newly header bar hideable HOT 6
- background with alpha unexpected behavior HOT 2
- Sign Up and Login Page for Hindi language is still in English HOT 1
- loadImage results in "failed to fetch" with most images. HOT 2
- assign a custom icon to a file type HOT 4
- Glitches in `banner` when dragging the `console` HOT 1
- We are able to upload duplicate `file` HOT 3
- Wrong language is shown in the console. HOT 6
- Lines with a nullish coalescing assignment flags an error HOT 1
- Intermittent asset loading errors in Safari HOT 8
- Mobile version file name layout is broken HOT 5
- Signup & login pages are cropped on both side HOT 3
- Keyword Syntax highlighting still outdated HOT 4
- Add @media print CSS statements to be able to get usefull pdf formatting HOT 6
- Sign-Up Page Broken HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5.js-web-editor.