Comments (4)
Or we could instead display the
EmailVerificationView.InvalidTokenNull
message for the invalid token as well.
Hmm the name "InvalidTokenNull" does suggest that it was intended to be used for both null and invalid tokens, doesn't it? I'm going to see if I can dig up the issues and PR from back when this was first implemented to see what was discussed then.
from p5.js-web-editor.
@lindapaiste How would you like to proceed with this?
Currently, we are displaying the message EmailVerificationView.InvalidState
in case the token is invalid.
We could either change this message for every translation file to something more appropriate like you suggested Token is invalid or expired
.
Or we could instead display the EmailVerificationView.InvalidTokenNull
message for the invalid token as well.
from p5.js-web-editor.
I checked the history and we have always displayed the "something went wrong" message. This is potentially related to #1587, because we get back a more descriptive message from the server but it's not translated. PR #2898 opens up the ability to translate the message from the backend. We could also change the translation on the frontend.
from p5.js-web-editor.
@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull
message, since we already have translations for it.
from p5.js-web-editor.
Related Issues (20)
- Making 'Sublime Text shortcuts.' hyperlink easily distinguishable with rest of the text. HOT 2
- The color of sketch link in sketches table should be changed to theme color when hovered
- Add reset font size button HOT 4
- Discussion: `TextLink` component HOT 8
- Implementing Pagination while rendering examples HOT 8
- Add a arrow key to toggle Sketch Files Section HOT 3
- Bug: link is not bold or hover effect on Keyboard Shortcuts page HOT 1
- Add transitions when user open files HOT 3
- Using Zod Library to validate inputs entered by the users in signup form and login forms. HOT 8
- No indication that the current password entered is incorrect when changing password HOT 4
- Run accessibility checks in dev mode using `@axe-core/react` HOT 4
- Semantic HTML issues in header section HOT 1
- "Create Collection" button & text area overflowing outside the dialog box. HOT 3
- No password confirmation when resetting a password HOT 4
- About Page not aligned properly for mobile users. HOT 2
- Discussion: deleting an asset should remove it from projects HOT 10
- Overflow Issue in Upload Modal HOT 1
- Collections Rename Input Fails to Autofocus. HOT 2
- Signup Section is not aligned properly. HOT 5
- Evaluate redundant redirects between client and server HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5.js-web-editor.