Git Product home page Git Product logo

Comments (4)

lindapaiste avatar lindapaiste commented on July 18, 2024 1

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

Hmm the name "InvalidTokenNull" does suggest that it was intended to be used for both null and invalid tokens, doesn't it? I'm going to see if I can dig up the issues and PR from back when this was first implemented to see what was discussed then.

from p5.js-web-editor.

aryanas159 avatar aryanas159 commented on July 18, 2024

@lindapaiste How would you like to proceed with this?

image

Currently, we are displaying the message EmailVerificationView.InvalidState in case the token is invalid.

We could either change this message for every translation file to something more appropriate like you suggested Token is invalid or expired.

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

from p5.js-web-editor.

lindapaiste avatar lindapaiste commented on July 18, 2024

I checked the history and we have always displayed the "something went wrong" message. This is potentially related to #1587, because we get back a more descriptive message from the server but it's not translated. PR #2898 opens up the ability to translate the message from the backend. We could also change the translation on the frontend.

from p5.js-web-editor.

aryanas159 avatar aryanas159 commented on July 18, 2024

@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull message, since we already have translations for it.

from p5.js-web-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.