Find and Replace dialog box is not mobile-responsive about p5.js-web-editor HOT 5 OPEN

Hi @lindapaiste I would like to work on the issue if validated.

Yes please do, that's definitely a mistake.

from p5.js-web-editor.

Hello, @lindapaiste should I leave space such that the editor is fully visible, or should the dialogue box cover the editor like in the example below?

Good question! I didn't even think about that! I was thinking that it was just a z-index issue. But what if the text that you are replacing is in the first 2 lines of the code which are covered up? I think that ideally we would shift the content down but that might be difficult to do given the hierarchy of the components.

The Editor would need to know that the find/replace modal is open. So we would need to pass around a lot of state. Well...actually...I think we can tell if the modal is open by looking at the internal state of the CodeMirror instance this._cm. But I would have to dig into the docs to figure out how to do that.

It would definitely be an improvement just to fix the z-index. So maybe we start with that, and revisit layout changes later?

from p5.js-web-editor.

Hi @lindapaiste I would like to work on the issue if validated.

from p5.js-web-editor.

Hello, @lindapaiste should I leave space such that the editor is fully visible, or should the dialogue box cover the editor like in the example below?

from p5.js-web-editor.

It would definitely be an improvement just to fix the z-index. So maybe we start with that, and revisit layout changes later?

Great I will push the z-index changes for now

from p5.js-web-editor.