Comments (7)
9401adarsh
commented on September 24, 2024
1
Thanks for the pointers, will keep you posted of the progress here.
from privatebin.
9401adarsh
commented on September 24, 2024
1
Hello, sorry wasn't able to get back in the last couple of weeks. I have made the changes to the privatebin.js file as per your suggestion, and have run the unit tests.
Modified downloadText() method:
function downloadText()
{
var fileFormat = PasteViewer.getFormat() === 'markdown' ? '.md' : '.txt';
var filename = 'paste-' + Model.getPasteId() + fileFormat;
var text = PasteViewer.getText();
var element = document.createElement('a');
element.setAttribute('href', 'data:text/plain;charset=utf-8,' + encodeURIComponent(text));
element.setAttribute('download', filename);
element.style.display = 'none';
document.body.appendChild(element);
element.click();
document.body.removeChild(element);
}
Unit Test Log:
PHPUnit 10.5.20 by Sebastian Bergmann and contributors.
Runtime: PHP 8.2.18
Configuration: /home/adarsh9401/Desktop/Dev/PrivateBin/tst/phpunit.xml
D.............................................................. 63 / 369 ( 17%)
............................................................... 126 / 369 ( 34%)
............................................................... 189 / 369 ( 51%)
............................................................... 252 / 369 ( 68%)
........................DDDDDD................................. 315 / 369 ( 85%)
...................................................... 369 / 369 (100%)
Time: 00:31.538, Memory: 20.00 MB
There were 2 PHPUnit test runner warnings:
1) Class Bootstrap cannot be found in /home/adarsh9401/Desktop/Dev/PrivateBin/tst/Bootstrap.php
2) XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set
--
There was 1 PHPUnit test runner deprecation:
1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!
--
1 test triggered 1 PHPUnit deprecation:
1) JsonApiTest::testShortenViaYourls
Data Provider method JsonApiTest::baseUriProvider() is not static
/home/adarsh9401/Desktop/Dev/PrivateBin/tst/JsonApiTest.php:290
WARNINGS!
Tests: 369, Assertions: 6084, Warnings: 2, Deprecations: 3.
Screenshot to show that file is downloaded as .md:
Is this good to go ?
from privatebin.
rugk
commented on September 24, 2024
1
Sure, if it is good create a pull request and we can review it and suggest changes, if needed.
from privatebin.
9401adarsh
commented on September 24, 2024
1
Will create a pull request from my feature branch of the forked repo to the master branch of the official repo. Hope that works ?
from privatebin.
9401adarsh
commented on September 24, 2024
Hey there, can I take up this issue ? Would appreciate it if someone could lend a few pointers on where to begin.
from privatebin.
elrido
commented on September 24, 2024
Sure thing, go for it. It should not be too complicated, the filename is the first thing generated in the TopNav.downloadText method:
Lines 3825 to 3834 in 28f3e54
You could look up the current format using the PasteViewer.getFormat method - you would look for it to be markdown to change the suffix to .md.
from privatebin.
rugk
commented on September 24, 2024
Sure, it should, just do it.
from privatebin.
Related Issues (20)
- When shorten the url, link should be opened in a new window HOT 2
- Removing page template and cleaning up code HOT 2
- PHP 8.4 tests failing HOT 2
- 1.7.2 / valid to / paste lifetime / lease time / always 23 hours HOT 11
- Feature Request: Rephrase the WebAssembly error on unsupported browsers HOT 2
- bs5 file upload too small
- bs5 sourcecode highlighting hard to read
- S3 provider broken in 1.7.2 HOT 2
- bs5 text wrapping in menu bar instead of collapsing HOT 5
- In version 1.7.2, the user-selected expiration is ignored HOT 5
- End-to-end testing with PHP backend and JS Frontend
- Improve JS (Frontend) unit testing coverage HOT 13
- Could not create paste: Error saving paste. Sorry. (1.7.2 and later) HOT 7
- bs5 feedback HOT 8
- "Dark mode" toggle in Bootstrap 5 theme is not syncronised with prefers-color-scheme at start (when dark)
- Default Content-Security-Policy blocks bootstrap5 icons HOT 1
- Error saving paste. Sorry. since 1.7.3 (database storage) - don't forget to reset your table paste HOT 1
- Bootstrap(5) and footer feedback (textarea height) HOT 1
- Wrong translation for Norwegian popup HOT 1
- BS5 light-mode as source is hard to read HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privatebin.