Comments (8)
You are right, need to get that updated. Hopefully someone from the community who it bothers will step in and submit a pull request with those fixes (hint hint) :)
Seriously though, please do if you have time. We'll keep this in the backlog if not and try to get to it when we can.
from prism-samples-wpf.
OK, may be I will do it.
from prism-samples-wpf.
I did it, and I'm trying to send a pull request but I get a message that i don't have permissions.
from prism-samples-wpf.
I suppose you did commit to your own fork and not this repository? As others can send a PR, I think everything permission-wise should be ok (unless one of the brians changed it lately).
from prism-samples-wpf.
No changes that I am aware of.
So did you get your changes checked in to your own fork and push'ed up to GitHub? Is the error happening when you press the "Compare, Review and Create a Pull Request" green button to the upper left of the list of files in your fork?
If you can give some more information we can try to help you through it. Or if you just want to send me a zip of what you have I can get it checked in for you but will still need you to sign a CLA:
https://cla2.dotnetfoundation.org/
Thanks
Brian
from prism-samples-wpf.
I hope I did everything right ..
from prism-samples-wpf.
Your pull request was under your own repo, not the Prism one. There were a number of changes I would have made to it anyway, so just went and updated the sample myself.
from prism-samples-wpf.
OK, a good job, but some comments:
- I think that using ObservableCollection as Notify-property is anti-pattern.
Instead of:
public ObservableCollection<Meeting> Meetings
{
get { return meetings; }
set { SetProperty(ref meetings, value); }
}
Instead of this, we can use List<Meeting>
, or like you did in ContactsViewModel: mettings.ForEach ....
But in my opinion, the best way to initialize collection is using extension method:
using System.Collections.Generic;
using System.Collections.ObjectModel;
namespace ViewSwitchingNavigation.Infrastructure
{
public static class ObservableCollectionExtensions
{
public static void AddRange<T> (this ObservableCollection<T> targetCollection,IEnumerable<T> source)
{
foreach(T item in source)
{
targetCollection.Add(item);
}
}
}
}
//====================//
Instead of:
contactsServiceMock
.Setup(svc => svc.GetContactsAsync())
.Returns(Task.FromResult(contacts));
You can write:
contactsServiceMock
.Setup(svc => svc.GetContactsAsync())
.ReturnsAsync(contacts);
from prism-samples-wpf.
Related Issues (20)
- Project paths are wrong HOT 1
- UsingCustomWindow: Example incomplete and does not work when completed HOT 2
- project 12(UsingCompositeCommands) is exactly the same as project 13( IActiveAwareCommands) HOT 1
- why do wpf sample need prism-unity? HOT 3
- want .net framework samples HOT 1
- 12-UsingCompositeCommands error HOT 1
- 21-PassingParameters “PersonList.xaml” has a little problem on my computer HOT 2
- Where are examples of interactivity HOT 1
- [Question] Is it possible to implement 07-Modules - LoadManual to xamarin HOT 1
- Prism Interactivity InteractionRequest alternative in Prism 8.x as InteractionRequest is obsolete now HOT 1
- I want to provide a sample about dialog service HOT 5
- Overall Solution file HOT 3
- How to use Prism in Extensions for Visual Studio? HOT 1
- VS2017 can't open the *.csproj; Which Visual Studio Version should we use to open the *.csproj? HOT 1
- [Qusetion] Bootstrapper or App.g.i.cs change.. What's better? HOT 1
- How to read appsetting.json from prism application?
- How do I get all registered views in WPF HOT 1
- 25 HOT 1
- Blank window samples HOT 2
- Why is it so hard to use regions? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prism-samples-wpf.