Git Product home page Git Product logo

Comments (6)

kmantel avatar kmantel commented on July 17, 2024

In general this should now be true, in that we consider pushes to master to correspond to a release. It's possible that there have been problems with the build server that generates the documentation, because when this issue was posted we had already released v0.4.6.0, and at the moment the version on the docs seems to be correct. I'm going to try to pinpoint the cause of this

from psyneulink.

jvesely avatar jvesely commented on July 17, 2024

@kmantel, I think this one should be fixed.
The current script updates branches/$BRANCH on push to master, devel, and docs branches.
The root documentation is only updated on tags present on master, other pushes to master do not regenerate the root docs (only branches/master)

from psyneulink.

jdcpni avatar jdcpni commented on July 17, 2024

from psyneulink.

kmantel avatar kmantel commented on July 17, 2024

@kmantel, I think this one should be fixed.
The current script updates branches/$BRANCH on push to master, devel, and docs branches.
The root documentation is only updated on tags present on master, other pushes to master do not regenerate the root docs (only branches/master)

Checking https://princetonuniversity.github.io/PsyNeuLink/branch/master/, the version is 0.8.5.1+47, and the version of the parent commit of current master is 0.8.5.1+46. I'm guessing the cause of the original problem (if it wasn't entirely before we'd push a new tag on each push to master) was jenkins building docs for the master push before the updated tag was pushed, resulting in the + version in the same way. From what I can see, the Action would handle this. Has the problem happened again?

from psyneulink.

jvesely avatar jvesely commented on July 17, 2024

@kmantel, I think this one should be fixed.
The current script updates branches/$BRANCH on push to master, devel, and docs branches.
The root documentation is only updated on tags present on master, other pushes to master do not regenerate the root docs (only branches/master)

Checking https://princetonuniversity.github.io/PsyNeuLink/branch/master/, the version is 0.8.5.1+47, and the version of the parent commit of current master is 0.8.5.1+46. I'm guessing the cause of the original problem (if it wasn't entirely before we'd push a new tag on each push to master) was jenkins building docs for the master push before the updated tag was pushed, resulting in the + version in the same way. From what I can see, the Action would handle this. Has the problem happened again?

The commit ussually comes before the tag, since the commit created on gh and the tag is added after.
Nothing new here, just checking if this can be closed since it looks fixed.

from psyneulink.

kmantel avatar kmantel commented on July 17, 2024

Ok, I think we can consider it fixed by #1888.

from psyneulink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.